+
Skip to content

Feature/test datasets #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 7, 2025
Merged

Feature/test datasets #3548

merged 15 commits into from
May 7, 2025

Conversation

JulianFlesch
Copy link
Contributor

@JulianFlesch JulianFlesch commented Apr 28, 2025 •
edited
Loading

This PR addresses usability improvements that were suggested by @ewels and @mashehu for the new test-datasets subcommand.
Changes:

  • Order of subcommands in nf-core -h changed
  • Help texts in nf-core test-datasets -h shortened
  • Optional query argument added to nf-core test-dataset search which pre-populates the autocomplete. If query is unambiguous, autocomplete is skipped.
  • Parameter --branch is attempted to be inferred from the current working dir to pre-populate the autocomplete

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (94c8eff) to head (10051de).
Report is 37 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/test_datasets/test_datasets_utils.py 14.28% 12 Missing ⚠️
nf_core/test_datasets/search.py 0.00% 5 Missing ⚠️
nf_core/__main__.py 75.00% 1 Missing ⚠️
nf_core/commands_test_datasets.py 50.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewels
Copy link
Member

ewels commented Apr 29, 2025

Waiting for @mashehu to review (and @mirpedrol ?)

mashehu
mashehu approved these changes Apr 29, 2025
View reviewed changes
@JulianFlesch
Copy link
Contributor Author

Can I merge this when tests have run @mashehu?

mirpedrol
mirpedrol approved these changes Apr 30, 2025
View reviewed changes
@JulianFlesch JulianFlesch merged commit 742897d into nf-core:dev May 7, 2025
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JulianFlesch @ewels @mashehu @mirpedrol @nf-core-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载