+
Skip to content

bump nf-schema to 2.4.2 and nextflow to 24.10.8 #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 23, 2025

Conversation

nvnieuwk
Copy link
Contributor

This PR bumps nf-schema to 2.4.0 and Nextflow to 24.10.0 as this is the new minimal version for nf-schema

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

@maxulysse
Copy link
Member

Let's wait before we merge this one, 2.4.0 has a small issue that we discovered with @nvnieuwk

@nvnieuwk
Copy link
Contributor Author

Yes working on this now, hope to have the fix released by tomorrow

@maxulysse maxulysse changed the title bump nf-schema to 2.4.0 bump nf-schema to 2.4.1 Apr 10, 2025
nvnieuwk and others added 2 commits April 10, 2025 15:09
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
@nvnieuwk
Copy link
Contributor Author

Thanks @maxulysse !

@nvnieuwk
Copy link
Contributor Author

@mashehu any idea on what is going on with the CI here?

@mashehu
Copy link
Contributor

mashehu commented Apr 10, 2025

It's the branch protection rules. You need to update them for the new test names.

@nvnieuwk
Copy link
Contributor Author

Okay can you approve this PR first? That way I can directly merge it in after changing the branch protection and thus causing the least issues for all other PRs

mashehu and others added 4 commits June 17, 2025 11:28
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@mashehu mashehu changed the title bump nf-schema to 2.4.1 bump nf-schema to 2.4.2 and nextflow to 24.10.8 Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.83%. Comparing base (fb0b735) to head (d70172c).
Report is 3 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu requested a review from mirpedrol June 17, 2025 15:40
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged now, the bump of the Nextflow version is approved by maintainers (see Slack thread)

@mashehu mashehu merged commit 77d258f into nf-core:dev Jun 23, 2025
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载