+
Skip to content

Drop python 3.8, add tests with python 3.13 #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 17, 2025
Merged

Drop python 3.8, add tests with python 3.13 #3538

merged 9 commits into from
Jun 17, 2025

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Apr 15, 2025

also drop testing ubuntu 20.04 as it reaches its end of LTS.

a-penguin-wearing-a-top-hat-with-the-words-time-s-up

@mashehu mashehu requested a review from mirpedrol April 15, 2025 15:10
@mashehu mashehu added this to the 3.4.0 milestone Apr 15, 2025
@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.83041% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.74%. Comparing base (24ff598) to head (a17d99a).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/components/info.py 80.00% 1 Missing ⚠️
nf_core/pipelines/lint_utils.py 87.50% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu mentioned this pull request May 27, 2025
Merged
mirpedrol
mirpedrol approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mashehu
Merge branch 'dev' of github.com:nf-core/tools into add-py-3_13
a17d99a 
# Conflicts:
#	CHANGELOG.md
#	nf_core/test_datasets/search.py
#	nf_core/test_datasets/test_datasets_utils.py
@mashehu mashehu merged commit fb0b735 into nf-core:dev Jun 17, 2025
165 of 166 checks passed
@mashehu mashehu deleted the add-py-3_13 branch June 17, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载