+
Skip to content

Refactor adding EDAM ontologies and allowing detect more patterns (e.g., versions.yml) #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025

Conversation

toniher
Copy link
Member

@toniher toniher commented Mar 27, 2025

Refactor ontologies addition code (common in input and output)

Addressing assignation of files (versions.yml) and also addressing issues such as #3496

@toniher toniher requested a review from mirpedrol March 27, 2025 17:51
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (8d21cdf) to head (e8769c0).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/modules/lint/__init__.py 89.65% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice that you could reduce code duplication 👏

missing ontologies key

Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@toniher toniher merged commit 52dfee6 into nf-core:dev Mar 28, 2025
95 checks passed
@toniher toniher deleted the further-check-ontology branch March 28, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载