+
Skip to content

Update dead link #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update dead link #3505

wants to merge 1 commit into from

Conversation

Aratz
Copy link
Contributor

@Aratz Aratz commented Mar 24, 2025

While going through the list of todos for nf-core/seqinspector I found a dead link. The link is now fixed.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@Aratz Aratz self-assigned this Mar 24, 2025
@Aratz Aratz marked this pull request as ready for review March 24, 2025 17:45
@Aratz Aratz requested review from mashehu and mirpedrol March 24, 2025 17:45
@Aratz
Copy link
Contributor Author

Aratz commented Mar 24, 2025

Wait, I'm not sure how this happened, but it looks like my commit ended up on dev already 🙈 (815f972)

I shouldn't be allowed to push directly to the origin repo, right? Can you please check and tell me what I did wrong?

@nikhil
Copy link
Contributor

nikhil commented Mar 24, 2025

Hey @Aratz, it seems that you were able to force push into dev. I think that can be disabled in settings

@mashehu
Copy link
Contributor

mashehu commented Mar 24, 2025

the problem was probably that you pushed from a branch called dev, then our changelog automation sometimes seems to be pushing to the same branch on tools, that's why it might have ended up there. Haven't had time to thoroughly test that theory, but you are not the first one to happen this to.

@Aratz
Copy link
Contributor Author

Aratz commented Mar 25, 2025

I see, in the future, I'll make sure to use feature branches, thanks for the explanation, I'll close this PR then 👍

@Aratz Aratz closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载