+
Skip to content

Conversation

matbonfanti
Copy link
Contributor

@matbonfanti matbonfanti commented Jan 30, 2025

Bug Fix of #3434 : Incorrect Argument Type in write_params_file()

When running the command nf-core pipelines create-params-file, an AttributeError was raised because the write_params_file() method of ParamsFileBuilder expected its first argument to be a Path object. However, a string representing the output parameter file name was passed instead, causing the error.
This fix ensures that the argument is properly converted to a Path object before being passed to write_params_file(), resolving the issue.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for finding and fixing this bug!

@mashehu mashehu enabled auto-merge January 30, 2025 09:29
@mashehu mashehu merged commit 2bbdb87 into nf-core:dev Jan 30, 2025
90 checks passed
@matbonfanti matbonfanti deleted the fix-create-params-file branch February 3, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载