+
Skip to content

Add no clobber and put bash options on their own line #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2024
Merged

Add no clobber and put bash options on their own line #2991

merged 2 commits into from
May 22, 2024

Conversation

mahesh-panchal
Copy link
Member

  • Adds the bash option no clobber
  • Put each option on it's own line and explain what it does.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

nvnieuwk
nvnieuwk reviewed May 21, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.11%. Comparing base (d4b8af2) to head (589265e).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nvnieuwk
nvnieuwk reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd rather have someone else look at this too since I'm not that familiar with this

@mirpedrol
Copy link
Member

Hi @mahesh-panchal, do you have a link to docs about the no clobber option?

@mahesh-panchal
Copy link
Member Author

https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html

@mirpedrol
Copy link
Member

Thanks! Could this break any existing pipelines which might be using this redirection?

@mahesh-panchal
Copy link
Member Author

I'm not aware of any modules that are purposely overwriting files. We normally add checks to prevent that.

mirpedrol
mirpedrol approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for double checking, looks good to me then 🙂

@mahesh-panchal mahesh-panchal merged commit fd7ca28 into nf-core:dev May 22, 2024
@mahesh-panchal mahesh-panchal deleted the add_noclobber branch May 22, 2024 13:49
@ewels ewels mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvnieuwk nvnieuwk nvnieuwk left review comments

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahesh-panchal @mirpedrol @nvnieuwk @nf-core-bot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载