+
Skip to content

Minor tweaks #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

Minor tweaks #986

merged 2 commits into from
Apr 7, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 31, 2021

Couple of minor fixes for things that I spotted whilst doing stuff this evening.

  • Fix list indentation for correct GitHub rendering. GitHub needs 4 spaces, markdownlint likes 2. I have added a mdl comment to avoid the mdl linting from triggering a CI error.
  • Schema build - add exception type to handle. This is one I ran into and I don't know why. I couldn't replicate it but figured that I could catch it properly next time.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #986 (e2094ab) into dev (0ce2c58) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #986      +/-   ##
==========================================
- Coverage   69.27%   69.21%   -0.06%     
==========================================
  Files          34       34              
  Lines        4250     4256       +6     
==========================================
+ Hits         2944     2946       +2     
- Misses       1306     1310       +4
Impacted Files Coverage Δ
nf_core/utils.py 79.79% <0.00%> (ø)
nf_core/sync.py 51.50% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d83a3...e2094ab. Read the comment docs.

KevinMenden
KevinMenden approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drpatelh drpatelh merged commit a3214aa into nf-core:dev Apr 7, 2021
@ewels ewels deleted the minor-tweaks branch April 7, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMenden KevinMenden KevinMenden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewels @KevinMenden @drpatelh
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载