Refactor: Eliminate SCRIPT_DIR duplication in claude-quick script #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Skogix <690279+Skogix@users.noreply.github.com>
Copilot finished work on behalf of
Skogix
October 9, 2025 10:41
There was a problem hiding this comment.
Pull Request Overview
This PR eliminates code duplication by consolidating three identical SCRIPT_DIR calculations into a single variable declaration at the top of the script, improving maintainability and following DRY principles.
- Moved
SCRIPT_DIRcalculation from multiple locations to a single declaration at script initialization - Removed three duplicate
SCRIPT_DIRcalculations scattered throughout conditional branches - Added descriptive comment explaining the variable's purpose
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
SCRIPT_DIRcalculation was duplicated three times in thescripts/claude-quickscript (lines 68, 82, and 89), violating the DRY (Don't Repeat Yourself) principle and making the code harder to maintain.Solution
Moved the
SCRIPT_DIRcalculation to a single variable declaration at the top of the script (afterset -e), eliminating the redundant calculations. The variable is now calculated once and reused throughout the script.Changes
SCRIPT_DIRdeclaration at the top of the script with descriptive commentSCRIPT_DIRcalculations that were scattered in different conditional branchesBenefits
Validation
✅ Shellcheck passes
✅ Bash syntax validation successful
✅ SCRIPT_DIR calculation verified to work correctly
✅ All referenced scripts (
claude-issue,claude-pr) exist and are executableFixes #17
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.