-
Notifications
You must be signed in to change notification settings - Fork 15
feat: added @hono/mcp package #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yusukebe I have added a simple test to check if the error is getting thrown or not, and the original tests are also passing. Is it okay, or should I add more test? |
|
This may not be the Ramen API thing, but a it('Should return 200 for GET request without headers', async () => {
const res = await app.request('/mcp')
expect(res.status).toBe(200)
})Is this expected behavior? |
|
Yes, it is. This is happens in the official SDK also https://github.com/honojs/middleware/blob/main/packages/mcp/src/index.ts#L89-L102 |
|
This is in the official one - https://github.com/modelcontextprotocol/typescript-sdk/blob/main/src/server/streamableHttp.ts#L155-L167 |
|
I think we won't be able to get rid of |
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @MathurAditya724 ! Thank you for the explanation. I got it. Looks good. Thank you for the contribution to Ramen API 🍜 |
Resolves #30