这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MathurAditya724
Copy link
Contributor

Resolves #30

@MathurAditya724 MathurAditya724 requested a review from yusukebe June 18, 2025 05:22
@MathurAditya724
Copy link
Contributor Author

@yusukebe I have added a simple test to check if the error is getting thrown or not, and the original tests are also passing. Is it okay, or should I add more test?

@yusukebe
Copy link
Owner

@MathurAditya724

This may not be the Ramen API thing, but a @hono/mcp matter. The response for a GET request without proper headers will be 500. The following test will fail:

it('Should return 200 for GET request without headers', async () => {
  const res = await app.request('/mcp')
  expect(res.status).toBe(200)
})

Is this expected behavior?

@MathurAditya724
Copy link
Contributor Author

Yes, it is. This is happens in the official SDK also https://github.com/honojs/middleware/blob/main/packages/mcp/src/index.ts#L89-L102

@MathurAditya724
Copy link
Contributor Author

@MathurAditya724
Copy link
Contributor Author

I think we won't be able to get rid of onError handler, so I am adding it back

Copy link
Owner

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Owner

Hi @MathurAditya724 !

Thank you for the explanation. I got it. Looks good. Thank you for the contribution to Ramen API 🍜

@yusukebe yusukebe merged commit 4b05e8c into yusukebe:master Jun 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add support for @hono/mcp

2 participants