-
Notifications
You must be signed in to change notification settings - Fork 49
feat: add MessageChannel polyfill to support react 19 #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MessageChannel polyfill to support react 19 #238
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just submitting my review. You should just revert the changes on the pnpm-lock
file since no dependencies are changed.
I also performed some debug on the issue Valerio reported but I'm posting what I discovered in a separate comment.
Warning
Note for myself: after closing the issue open a task to address review comment posted below
Sounds perfect! Thanks for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for it!
add MessageChannel polyfill to support react 19
Related to #218