这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor: enable typescript-eslint strict rules #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2024
Merged

refactor: enable typescript-eslint strict rules #243

merged 1 commit into from
Dec 22, 2024

Conversation

marcalexiei
Copy link
Collaborator

Context & Description

Followup of #238 (comment)

  • enabled strictTypeChecked config rule
  • remove redundant rules definition from eslint.config.mjs
  • resolved new eslint errors coming from the following rules:
    • @typescript-eslint/no-confusing-void-expression
    • @typescript-eslint/no-explicit-any

@marcalexiei marcalexiei added the repo maintenance linting, fs organization, that sort of stuff label Dec 22, 2024
@marcalexiei marcalexiei self-assigned this Dec 22, 2024
@marcalexiei marcalexiei marked this pull request as ready for review December 22, 2024 09:43
@Valerioageno Valerioageno self-requested a review December 22, 2024 11:08
Valerioageno
Valerioageno approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Valerioageno Valerioageno merged commit 77e22c4 into main Dec 22, 2024
7 checks passed
@Valerioageno Valerioageno deleted the chore/eslint-strict branch December 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valerioageno Valerioageno Valerioageno approved these changes

Assignees

@marcalexiei marcalexiei

Labels
repo maintenance linting, fs organization, that sort of stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalexiei @Valerioageno