这是indexloc提供的服务，不要输入任何密码
Skip to content

Added auto alpha tuning and exploration noise for sac. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2020
Merged

Added auto alpha tuning and exploration noise for sac. #80

merged 1 commit into from
Jun 16, 2020

Conversation

danagi
Copy link
Collaborator

@danagi danagi commented Jun 16, 2020

Added class BaseNoise and GaussianNoise for the concept of exploration noise.
Added auto alpha tuning and exploration noise for sac.
Added new test for sac tested in MountainCarContinuous-v0 which would be hard to explore without above new features.

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • If applicable, I have mentioned the relevant/related issue(s)

Less important but also useful:

  • I have visited the source website, and in particular read the known issues
  • I have searched through the issue tracker and issue categories for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable: 
    import tianshou, torch, sys
print(tianshou.__version__, torch.__version__, sys.version, sys.platform)

@danagi
Add auto alpha tuning and exploration noise for sac.
b05880a 
Add class BaseNoise and GaussianNoise for the concept of exploration noise.
Add new test for sac tested in MountainCarContinuous-v0,
which should benefits from the two above new feature.
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020 •
edited
Loading

Codecov Report

Merging #80 into master will increase coverage by 0.79%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   85.97%   86.76%   +0.79%     
==========================================
  Files          29       29              
  Lines        1704     1746      +42     
==========================================
+ Hits         1465     1515      +50     
+ Misses        239      231       -8
Flag Coverage Δ
#unittests 86.76% <95.65%> (+0.79%) ⬆️
Impacted Files Coverage Δ
tianshou/policy/modelfree/ddpg.py 98.76% <87.50%> (-0.02%) ⬇️
tianshou/exploration/random.py 94.59% <93.75%> (+57.09%) ⬆️
tianshou/exploration/__init__.py 100.00% <100.00%> (ø)
tianshou/policy/modelfree/sac.py 100.00% <100.00%> (ø)
tianshou/policy/modelfree/td3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2f05a...b05880a. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit c59ad40 into thu-ml:master Jun 16, 2020
@Trinkle23897 Trinkle23897 mentioned this pull request Aug 28, 2020
Closed
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
@danagi
Add auto alpha tuning and exploration noise for sac. (thu-ml#80)
20f5e7e 
Add class BaseNoise and GaussianNoise for the concept of exploration noise.
Add new test for sac tested in MountainCarContinuous-v0,
which should benefits from the two above new feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danagi @codecov-commenter @Trinkle23897