hotfix：fix test failure in cuda environment #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
reviewed
Feb 9, 2021
Trinkle23897
previously approved these changes
Feb 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 94.39% 94.40%
=======================================
Files 45 45
Lines 2892 2894 +2
=======================================
+ Hits 2730 2732 +2
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
finished I think, ready for review |
Trinkle23897
approved these changes
Feb 9, 2021
Merged
Trinkle23897
added a commit
that referenced
this pull request
Feb 16, 2021
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
Throw a warning in ListReplayBuffer. This version update is needed because of thu-ml#289, the previous v0.3.1 cannot work well under torch<=1.6.0 with cuda environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, if you run
pytest test --cov tianshou -s --durations 0 -von a gpu mechine, it will raise error(due to cuda/cpu data conversion)This pr fix that.