Add non in-place version of Batch.to_torch
#1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Breaking change: Previous in-place `Batch.to_torch` is now `Batch.to_torch_` (following naming convention of other in-place methods in codebase). * Update places where in-place was expected * Add tests for both to_torch/to_torch_
MischaPanch
approved these changes
Apr 17, 2024
|
Look good, thank you, merging this! For the future @dantp-ai: pls also modify the |
|
Sounds good. I actually thought I do the changelog commit after the review has finished, but it doesn't hurt to have it also in there for the review phase and update it too if necessarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1116
API Extensions
to_torch_. Add non in-place version ofBatch.to_torch#1117Breaking Changes
to_torchindata.utils.batch.Batchis not in-place anymore. Instead, a new methodto_torch_does the conversion in-place. Add non in-place version ofBatch.to_torch#1117