sbcl: added new solution #7625

metayan · 2021-09-30T13:01:50Z

Use SBCL if we have it already, otherwise ECL.
Build with ECL takes around seven times longer than with SBCL.
Yes, in true Lisp fashion, it can build itself. ;)
Possibility to use itself is useful for upgrades.

With the tweaks in the patch file, all internal tests pass.

ansi-test on termux-aarch64 reports 154 failures.
ansi-test on darwin-x8664 reports 145 failures.
So nothing to worry about.

#183 #948 #5415

metayan · 2021-09-30T14:10:52Z

Added $TERMUX_PREFIX/bin/ecl, so now ECL should be found.

By the way, the build using ECL takes around 45 minutes on my device. If the automatic build has a timeout set, it might need to be increased.

metayan · 2021-09-30T22:06:20Z

Getting

make-config.sh: 226: /data/data/com.termux/files/usr/bin/ecl: Exec format error

here during build.
As I see it it's an aarch64 executable in an aarch64 build. Or?

I have also blacklisted Intel builds now – I wrongly presumed that the blacklisting would propagate from the ecl dependency.

stale · 2021-11-18T13:51:55Z

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

metayan · 2021-11-18T14:41:08Z

This builds fine directly on the device, but haven't figured out how to build in Docker yet.
Any help with this is appreciated.

finagolfin · 2021-11-28T05:55:59Z

Please rebase.

Use SBCL if we have it already, otherwise ECL. Build with ECL takes around seven times longer than with SBCL. Yes, in true Lisp fashion, it can build itself. ;) Possibility to use itself is useful for upgrades. With the tweaks in the patch file, all internal tests pass. ansi-test on termux-aarch64 reports 154 failures. ansi-test on darwin-x8664 reports 145 failures. So most likely nothing to worry about.

Wrongly presumed that the ECL blacklisting would propagate

Spaces changed to tabs. https://github.com/termux/termux-packages/wiki/Coding-guideline

packages/sbcl/termux-tweaks.patch

finagolfin · 2021-11-28T09:27:06Z

packages/sbcl/termux-tweaks.patch

+   #include <sys/wait.h>
+   #include <sys/ioctl.h>
+-#if defined __HAIKU__ || defined __DragonFly__ || defined LISP_FEATURE_ANDROID
+#if defined __HAIKU__ || defined __DragonFly__ || defined LISP_FEATURE_ANDROID || defined __TERMUX__


LISP_FEATURE_ANDROID isn't defined?

Works with __ANDROID__ instead of __TERMUX__ .
Apparently LISP_FEATURE_ANDROID isn't defined. At least when building with SBCL.
Testing with ECL too now.

I'm trying to get it to build on device for now.
Building with SBCL that was built before works, but building with ECL fails now.

;;; Internal error: ;;; ** Error code 1 when executing ;;; (EXT:RUN-PROGRAM "aarch64-linux-android-clang" ("-I." "-I/data/data/com.termux/files/usr/include/" "-I/data/data/com.termux/files/usr/include" "-D_GNU_SOURCE" "-DPLATFORM_ANDROID" "-DUSE_GET_STACKBASE_FOR_MAIN" "-DIGNORE_DYNAMIC_LOADING" "-fstack-protector-strong" "-Oz" "-fPIC" "-D_THREAD_SAFE" "-Dandroid" "-O2" "-c" "/data/data/com.termux/files/usr/tmp/ecl001l5oZGt.c" "-o" "/data/data/com.termux/files/usr/tmp/ecl001l5oZGt.o")): ;;; In file included from /data/data/com.termux/files/usr/tmp/ecl001l5oZGt.c:5: ;;; In file included from /data/data/com.termux/files/usr/include/ecl/ecl-cmp.h:36: ;;; In file included from /data/data/com.termux/files/usr/include/ecl/ecl.h:22: ;;; In file included from /data/data/com.termux/files/usr/include/sys/types.h:33: ;;; In file included from /data/data/com.termux/files/usr/lib/clang/13.0.0/include/stdint.h:52: ;;; In file included from /data/data/com.termux/files/usr/include/stdint.h:32: ;;; In file included from /data/data/com.termux/files/usr/include/bits/wchar_limits.h:36: ;;; In file included from /data/data/com.termux/files/usr/include/sys/cdefs.h:371: ;;; /data/data/com.termux/files/usr/include/android/api-level.h:174:50: error: expected a platform name, e.g., 'macos' ;;; int android_get_application_target_sdk_version() __INTRODUCED_IN(24); ;;; ^ ;;; /data/data/com.termux/files/usr/include/android/versioning.h:62:36: note: expanded from macro '__INTRODUCED_IN' ;;; #define __INTRODUCED_IN(api_level) __BIONIC_AVAILABILITY(introduced=api_level) ;;; ^ ;;; /data/data/com.termux/files/usr/include/android/versioning.h:57:71: note: expanded from macro '__BIONIC_AVAILABILITY' ;;; #define __BIONIC_AVAILABILITY(__what) __attribute__((__availability__(android,strict,__what))) ;;; ^ ;;; <command line>:6:17: note: expanded from here ;;; #define android 1 ;;; ^ ;;; In file included from /data/data/com.termux/files/usr/tmp/ecl001l5oZGt.c:5: ;;; In file included from /data/data/com.termux/files/usr/include/ecl/ecl-cmp.h:36: ;;; In file included from /data/data/com.termux/files/usr/include/ecl/ecl.h:29: ;;; In file included from /data/data/com.termux/files/usr/include/stdio.h:47: ;;; In file included from /data/data/com.termux/files/usr/include/string.h:36: ;;; /data/data/com.termux/files/usr/include/bits/strcasecmp.h:56:87: error: expected a platform name, e.g., 'macos' ;;; int strcasecmp_l(const char* __s1, const char* __s2, locale_t __l) __attribute_pure__ __INTRODUCED_IN(23); ;;; ^ ;;; /data/data/com.termux/files/usr/include/android/versioning.h:62:36: note: expanded from macro '__INTRODUCED_IN' ;;; #define __INTRODUCED_IN(api_level) __BIONIC_AVAILABILITY(introduced=api_level) ;;; ^ ;;; /data/data/com.termux/files/usr/include/android/versioning.h:57:71: note: expanded from macro '__BIONIC_AVAILABILITY' ;;; #define __BIONIC_AVAILABILITY(__what) __attribute__((__availability__(android,strict,__what))) ;;; ^ ;;; <command line>:6:17: note: expanded from here ;;; #define android 1 ;;; ^

Will have to try more some other day.

This seem to be a new issue with ndk-r23, unrelated to sbcl. I can reproduce it with:

$ cat test.c #include <sys/types.h> int main() { return 0; }; $ clang -Dandroid test.c

finagolfin · 2021-11-28T09:31:11Z

This won't actually be used by almost anyone unless it's cross-compiled. You don't need Docker, any linux x86_64 distro will do to try building it with our packaging scripts.

- Fixes termux#948 - Partially fixes termux#24176 - Partially fixes termux#183 Previous attempts and progress: - termux@880983e (2016) - termux#7625 (2021) - termux#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852

- Fixes #948 - Partially fixes #24176 - Partially fixes #183 Previous attempts and progress: - 880983e (2016) - #7625 (2021) - #14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852

- Fixes termux/termux-packages#948 - Partially fixes termux/termux-packages#24176 - Partially fixes termux/termux-packages#183 Previous attempts and progress: - termux/termux-packages@880983e (2016) - termux/termux-packages#7625 (2021) - termux/termux-packages#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852

- Fixes termux#948 - Partially fixes termux#24176 - Partially fixes termux#183 Previous attempts and progress: - termux@880983e (2016) - termux#7625 (2021) - termux#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852

stale bot added the wontfix Issue won't be fixed label Nov 18, 2021

stale bot removed the wontfix Issue won't be fixed label Nov 18, 2021

metayan requested review from Grimler91, Neo-Oli, finagolfin, kcubeterm, landfillbaby, michalbednarski, ravener and thunder-coding as code owners November 28, 2021 05:29

metayan requested a review from a user November 28, 2021 05:29

Yan added 3 commits November 28, 2021 07:27

sbcl: specify ecl path

577a956

sbcl: disable Intel builds

a71c7dc

Wrongly presumed that the ECL blacklisting would propagate

metayan force-pushed the sbcl branch from 07069a1 to a71c7dc Compare November 28, 2021 06:31

Yan added 3 commits November 28, 2021 07:35

Only whitespace changes to comply with termux coding guidelines

27ba670

Spaces changed to tabs. https://github.com/termux/termux-packages/wiki/Coding-guideline

sbcl: update to 2.1.10

e9c4123

remove the blacklisting of i686 and x86_64

1cd2dce

finagolfin reviewed Nov 28, 2021

View reviewed changes

packages/sbcl/termux-tweaks.patch Outdated Show resolved Hide resolved

use correct termux tmp directory for tests

2bfa764

finagolfin reviewed Nov 28, 2021

View reviewed changes

packages/sbcl/termux-tweaks.patch Outdated Show resolved Hide resolved

finagolfin reviewed Nov 28, 2021

View reviewed changes

Yan added 2 commits November 28, 2021 10:52

use __ANDROID__ instead of __TERMUX__ in patch file

2a7c36e

trim leading / from path in sb-posix test

e03d0a8

Neo-Oli removed their request for review November 29, 2021 12:09

ravener removed their request for review December 15, 2021 16:10

ghost closed this Dec 30, 2021

robertkirkman mentioned this pull request Apr 18, 2025

addpkg(main/sbcl): 2.5.3 #24393

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

sbcl: added new solution #7625

sbcl: added new solution #7625

Uh oh!

metayan commented Sep 30, 2021

Uh oh!

metayan commented Sep 30, 2021

Uh oh!

metayan commented Sep 30, 2021

Uh oh!

stale bot commented Nov 18, 2021

Uh oh!

metayan commented Nov 18, 2021

Uh oh!

finagolfin commented Nov 28, 2021

Uh oh!

Uh oh!

Uh oh!

finagolfin Nov 28, 2021

Uh oh!

metayan Nov 28, 2021 •

edited

Loading

Uh oh!

metayan Nov 28, 2021

Uh oh!

Grimler91 Nov 29, 2021

Uh oh!

finagolfin commented Nov 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

sbcl: added new solution #7625

sbcl: added new solution #7625

Uh oh!

Conversation

metayan commented Sep 30, 2021

Uh oh!

metayan commented Sep 30, 2021

Uh oh!

metayan commented Sep 30, 2021

Uh oh!

stale bot commented Nov 18, 2021

Uh oh!

metayan commented Nov 18, 2021

Uh oh!

finagolfin commented Nov 28, 2021

Uh oh!

Uh oh!

Uh oh!

finagolfin Nov 28, 2021

Choose a reason for hiding this comment

Uh oh!

metayan Nov 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

metayan Nov 28, 2021

Choose a reason for hiding this comment

Uh oh!

Grimler91 Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

finagolfin commented Nov 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

metayan Nov 28, 2021 •

edited

Loading