new package: sbcl #14435
Closed
new package: sbcl #14435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2023
Grimler91
requested changes
Jan 10, 2023
Member
Grimler91
left a comment
There was a problem hiding this comment.
Thanks for the PR!
ecl needs to be installed in docker image, see comment
|
|
||
| termux_step_make() { | ||
| cd $TERMUX_PKG_SRCDIR | ||
| XC_HOST="$TERMUX_PREFIX/bin/ecl --norc --c-stack 16777217" |
Member
There was a problem hiding this comment.
This won't work for cross-compilation, can't run $TERMUX_PREFIX/bin/ecl in the ubuntu docker image. Instead /usr/bin/ecl from ubuntu, or some ecl compiled in termux_step_host_build, needs to be used.
Add ecl to setup-ubuntu.sh to install ubuntu's ecl in the docker image
Member
There was a problem hiding this comment.
I suppose ubuntu 22.04's ecl will be too old as well, so we might need to compile a newer ecl in a termux_step_host_build step for this to work
Author
There was a problem hiding this comment.
we might need to compile a newer ecl in a termux_step_host_build step for this to work
In that case, it would be better to use SBCL as the host. I will try to do it!
|
|
||
| termux_step_make() { | ||
| cd $TERMUX_PKG_SRCDIR | ||
| XC_HOST="$TERMUX_PREFIX/bin/ecl --norc --c-stack 16777217" |
Member
There was a problem hiding this comment.
indentation is different on this line compared to rest of the script (use tabs everywhere)
| - #+haiku '("-v") | ||
| - #-haiku '("-r") | ||
| - :output stream))))))) | ||
| + (run-program "/data/data/com.termux/files/usr/bin/uname" |
Member
There was a problem hiding this comment.
Please use @TERMUX_PREFIX@ instead of /data/data/com.termux/files/usr in patches, it is automatically sed'ed when patch is applied
Author
|
I can't commit to this task so I'm closing this PR. I may return to it one day. |
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Apr 18, 2025
- Fixes termux#948 - Partially fixes termux#24176 - Partially fixes termux#183 Previous attempts and progress: - termux@880983e (2016) - termux#7625 (2021) - termux#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Apr 18, 2025
- Fixes termux#948 - Partially fixes termux#24176 - Partially fixes termux#183 Previous attempts and progress: - termux@880983e (2016) - termux#7625 (2021) - termux#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Apr 18, 2025
- Fixes termux#948 - Partially fixes termux#24176 - Partially fixes termux#183 Previous attempts and progress: - termux@880983e (2016) - termux#7625 (2021) - termux#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852
robertkirkman
added a commit
that referenced
this pull request
Apr 26, 2025
- Fixes #948 - Partially fixes #24176 - Partially fixes #183 Previous attempts and progress: - 880983e (2016) - #7625 (2021) - #14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Apr 26, 2025
- Fixes termux/termux-packages#948 - Partially fixes termux/termux-packages#24176 - Partially fixes termux/termux-packages#183 Previous attempts and progress: - termux/termux-packages@880983e (2016) - termux/termux-packages#7625 (2021) - termux/termux-packages#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852
shadichy
pushed a commit
to shadichy/termux-packages
that referenced
this pull request
Apr 28, 2025
- Fixes termux#948 - Partially fixes termux#24176 - Partially fixes termux#183 Previous attempts and progress: - termux@880983e (2016) - termux#7625 (2021) - termux#14435 (2023) This PR mainly implements the package in a termux-packages downstream-oriented way (heavy use of internal termux-packages repository code shared with other termux-packages). There is discussion regarding the upstream-oriented way of implementation from the SBCL side (trying to non-cross-compile while avoiding use of any internal termux-packages repository code) here: https://bugs.launchpad.net/sbcl/+bug/1956852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBCL needs a host compiler to be built. Since we have ECL already packaged, it is a good candidate. However, using the latest release from ECL (21.2.1) fails to build SBCL, that's why I've bumped it.
I have tested this recipe locally and it works. I need help to be able to call
eclduringtermux_step_make. Could someone help me? Thanks.