enhance(scripts/lint-packages): ensure version changes #24948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ae9a39 to
195ff5d
Compare
licy183
reviewed
Jun 4, 2025
195ff5d to
a0f5563
Compare
licy183
reviewed
Jun 5, 2025
- Also fix a linter error (trailing whitespace, line 29) - Also ship `elvish` completions - and generate `zsh` completions instead of copying them
- Trailing whitespace on line 25 - and minor build script cleanup
- also don't reset package count between repo channels - don't use `$var` condition values as a command - clean up various shellcheck warnings
a0f5563 to
22b212c
Compare
Member
Author
|
I'd like to merge this in ~6 hours if there's no further comments or concerns. |
thunder-coding
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a linter step to ensure that any packages modified on a PR branch have either been updated to a new version, or have had their revision bumped.
This is being determined by a pretty basic
grepon the diffs of all commits betweenmaster/HEADandHEAD.I also fixed a bug in the linter that caused it to incorrectly continue after a failure.
This lead to trailing whitespace being committed into the
fdandpredictpackages.I have fixed those linter failures as part of this PR.
We also had a couple instances of
if "$check_var"; thenin the linter script.Treating variables as programs is generally discouraged so I have replaced those instances with a proper
if [[ "$check_var" == 'true' ]]; thenLastly I have moved the package counter out of being local to
linter_mainas this caused it to be reset between different repo channels (e.g.packages,root-packagesandx11-packages), it is now a proper cumulative count (and currently reports 2609 packages checked on a full run).