这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MohammadKHC
Copy link
Contributor

@MohammadKHC MohammadKHC commented Jun 3, 2025

When rust analyzer is built without CFG_RELEASE env it spams lsp with multiple warning when the main loop take too long to process a message. See this issue for more details
rust-lang/rust-analyzer#19754 (comment)
And also the build.rs file
https://github.com/rust-lang/rust-analyzer/blob/debaef80be92d957f52d6e89c86286556075ea47/crates/rust-analyzer/build.rs#L9

Also here is the function that logs the warnings when the RELEASE_CFG is not set.
https://github.com/rust-lang/rust-analyzer/blob/cf969d21c30fed7eac32d9e485dca4b39df826f8/crates/rust-analyzer/src/lsp/utils.rs#L109

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're gonna need to bump the package revision since this is a change to the package.
You just need to add TERMUX_PKG_REVISION=1 under the version line at the top of the build script.

Please make sure to squash and force push that change to this branch.


(This is a pre-written, saved reply.)
Please make sure to keep your commits squashed by the way.
For adding to a single commit you can use git commit --amend.
Since you already have multiple commits on your branch though,
you'll need to squash those with git rebase -i HEAD~<n> first.
(Where <n> is the number of commits you want to modify.
Please make sure to only modify your commits.)

https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits

Since squashing or amending commits changes the git history you will need to force push any such changes.
e.g. git push --force,
or preferably git push --force-with-lease --force-if-includes
to make sure you aren't clobbering any refs you haven't fetched locally yet.

When rust analyzer is built without CFG_RELEASE env it spams lsp with multiple warning when the main loop take too long to process a message. See this issue for more details
https://github.com/rust-lang/rust-analyzer/blob/debaef80be92d957f52d6e89c86286556075ea47/crates/rust-analyzer/build.rs#L9
@MohammadKHC
Copy link
Contributor Author

@TomJo2000 I added TERMUX_PKG_REVISION=1 just like you asked.

@MohammadKHC MohammadKHC requested a review from TomJo2000 June 3, 2025 18:08
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Will merge this after the CI finishes.

@MohammadKHC
Copy link
Contributor Author

@TomJo2000 Thanks!

@TomJo2000 TomJo2000 merged commit 2fa760d into termux:master Jun 3, 2025
9 checks passed
@TomJo2000
Copy link
Member

Thank you for your contribution. 👍

I did rewrite the commit message to be a bit shorter and to fit our commit message guidelines.
https://github.com/termux/termux-packages/blob/master/CONTRIBUTING.md#commit-guidelines

@MohammadKHC MohammadKHC deleted the patch-1 branch June 3, 2025 20:40
@MohammadKHC
Copy link
Contributor Author

Thanks actually the commit message was indeed bad. Will try to match that style in the future!

@TomJo2000
Copy link
Member

Thanks actually the commit message was indeed bad. Will try to match that style in the future!

I forgot to bring it up in the review earlier so I just fixed it as part of the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants