-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
aapt: Bump to 15.0.0.23 #23671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
aapt: Bump to 15.0.0.23 #23671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must have been a ton of effort.
Thank you a lot for your contribution.
I assume you have already done local/on-device testing,
but for anyone else reading this who may want to test this before it is merged I will leave instructions below.
(This is a pre-written, saved reply.)
If you want to test this PR please download the appropriate DEB package(s)
from the build artifacts of the associated PR's latest CI run.
After downloading the build artifact, make sure to unzip
and un-tar
it.
Detailed instructions, if needed.
# finding out what architecture you need
# architecture is just below the TERMUX_VERSION
termux-info
# e.g.
# [...]
# TERMUX_MAIN_PACKAGE_FORMAT=debian
# TERMUX_VERSION=0.118.0
# TERMUX__USER_ID=0
# Packages CPU architecture:
# aarch64
# [...]
# =======================
# make sure `unzip` and `tar` are installed using
pkg install unzip tar
# unzip the artifact (if you have a different architecture this might be arm, i686 or x86_64 instead)
unzip debs-aarch64-*.zip
# untar the artifact
tar xf debs-aarch64-*.tar
# You should now have a debs/ directory in your current working directory
# Install the packages from the local source using
pkg install -- ./debs/*.deb
# to clean up, you can remove the debs/ directory, .tar file and .zip file
rm -rfi debs debs-aarch64-*.zip debs-aarch64-*.tar
Ok, will fix and check arm and i686 fails tomorrow |
I was planning to replace the files in the aapt directory with https://github.com/termux/android-build-tools project. |
@Biswa96 |
I am sending simple patches to upstream, for example https://android-review.googlesource.com/c/platform/frameworks/native/+/3526633 and will try to simplify the maintenance. |
Any update?? Btw thanks for your work guys. I really appreciate it. |
@MohammedKHC0
on your device |
the command
|
Probably the branch should be rebased against current master. |
Is this fixed? |
@MohammedKHC0 |
Fixed this linking error, but it segfaults now at startup, will continue tomorrow |
conforming to android-35
Last commit should fix aapt2 If you don't want to wait for new artifacts
aapt, aapt2, aidl deb files will be in the also don't forget to install dependencies:
|
It seems that after #21562 aapt couldn't properly parse resources.arsc provided with android-35 platform
Updated it to 15.0.0.23
Fixes #21666
Didn't checked myself but probably also:
Fixes #22712
Fixes #22667
using CXXFLAGS+=" -fPIC -std=gnu++2b" because it used in base/libs/androidfw/Android.bp and fails with strange template errors on previous versions