aapt: Bump to 15.0.0.23 #23671

birhburh · 2025-03-08T03:10:16Z

It seems that after #21562 aapt couldn't properly parse resources.arsc provided with android-35 platform
Updated it to 15.0.0.23
Fixes #21666
Didn't checked myself but probably also:
Fixes #22712
Fixes #22667

using CXXFLAGS+=" -fPIC -std=gnu++2b" because it used in base/libs/androidfw/Android.bp and fails with strange template errors on previous versions

TomJo2000

This must have been a ton of effort.
Thank you a lot for your contribution.

I assume you have already done local/on-device testing,
but for anyone else reading this who may want to test this before it is merged I will leave instructions below.

^{(This is a pre-written, saved reply.)}
If you want to test this PR please download the appropriate DEB package(s)
from the build artifacts of the associated PR's latest CI run.

After downloading the build artifact, make sure to unzip and un-tar it.

Detailed instructions, if needed.

# finding out what architecture you need
# architecture is just below the TERMUX_VERSION
termux-info

# e.g.
# [...]
# TERMUX_MAIN_PACKAGE_FORMAT=debian
# TERMUX_VERSION=0.118.0
# TERMUX__USER_ID=0
# Packages CPU architecture:
# aarch64
# [...]

# =======================

# make sure `unzip` and `tar` are installed using
pkg install unzip tar

# unzip the artifact (if you have a different architecture this might be arm, i686 or x86_64 instead)
unzip debs-aarch64-*.zip

# untar the artifact
tar xf debs-aarch64-*.tar

# You should now have a debs/ directory in your current working directory
# Install the packages from the local source using
pkg install -- ./debs/*.deb

# to clean up, you can remove the debs/ directory, .tar file and .zip file
rm -rfi debs debs-aarch64-*.zip debs-aarch64-*.tar

birhburh · 2025-03-08T03:26:44Z

Ok, will fix and check arm and i686 fails tomorrow

Biswa96 · 2025-03-08T04:13:06Z

I was planning to replace the files in the aapt directory with https://github.com/termux/android-build-tools project.

birhburh · 2025-03-08T04:50:06Z

@Biswa96
It will be really awesome!
But probably will be a burden to catchup with AOSP changes in the future
Better then the current process of course

Biswa96 · 2025-03-08T05:00:07Z

But probably will be a burden to catchup with AOSP changes in the future

I am sending simple patches to upstream, for example https://android-review.googlesource.com/c/platform/frameworks/native/+/3526633 and will try to simplify the maintenance.

MohammadKHC · 2025-03-14T14:59:15Z

Any update??

Btw thanks for your work guys. I really appreciate it.

birhburh · 2025-03-14T18:31:45Z

@MohammedKHC0
Currently you can download artifacts as described in this comment
I tested that it works on armv7 and aarch64 now
Unzip it on your computer or on device and
And install needed deb package using:

apt install PATH_TO_DEB

on your device

Anonymous2716 · 2025-03-16T23:12:41Z

the command aapt2 of aarch64 arch artifact gives:

CANNOT LINK EXECUTABLE "aapt2": cannot locate symbol "png_sig_cmp" referenced by "/data/data/com.termux/files/usr/lib/libandroid-fw.so"...

twaik · 2025-04-18T10:46:58Z

the command aapt2 of aarch64 arch artifact gives:

CANNOT LINK EXECUTABLE "aapt2": cannot locate symbol "png_sig_cmp" referenced by "/data/data/com.termux/files/usr/lib/libandroid-fw.so"...

Probably the branch should be rebased against current master.

MohammadKHC · 2025-05-14T11:12:54Z

the command aapt2 of aarch64 arch artifact gives:

CANNOT LINK EXECUTABLE "aapt2": cannot locate symbol "png_sig_cmp" referenced by "/data/data/com.termux/files/usr/lib/libandroid-fw.so"...

Is this fixed?

MohammadKHC · 2025-05-22T19:43:56Z

@twaik @birhburh Sorry for the ping but is there is any work begining done?
Also please tell me if there is anyway i can help. Aapt is really needed at many IDEs for Android.

birhburh · 2025-05-23T16:58:04Z

@MohammedKHC0
Will try to fix it today

birhburh · 2025-05-24T00:17:43Z

Fixed this linking error, but it segfaults now at startup, will continue tomorrow

conforming to android-35

birhburh · 2025-06-29T02:13:23Z

@MohammedKHC0

Last commit should fix aapt2
It works for me on waydroid
at least no segfault on start and it shows help
Will test on real devices and update this comment: works on arm64 device, works on arm32 device
I think, rerun of CI needed for new artifacts

If you don't want to wait for new artifacts
Clone my repo (or fetch this pr branch for this repo) and run for arm64:

./scripts/run-docker.sh ./build-package.sh aapt -i

aapt, aapt2, aidl deb files will be in the output dir

also don't forget to install dependencies:

apt install fmt libc++ libexpat libpng libzopfli zlib

probably only for arm32 build:
also I should link this libraries statically or add them as dependencies but for now you also need:
apt install libprotobuf abseil-cpp
works on clean termux install on arm32 just with apt install PATH_TO_AAPT; apt install PATH_TO_AAPT2

robertkirkman · 2025-08-25T05:35:59Z

packages/aapt/build.sh

-_TAG_VERSION=13.0.0
-_TAG_REVISION=6
+_TAG_VERSION=15.0.0
+_TAG_REVISION=23


Can it be revision 36 which is the newest of this major version (or version 16.0.0 revision 2 which exists and is the newest overall)?

robertkirkman · 2025-08-25T05:37:29Z

packages/aapt/build.sh

+_TAG_VERSION=15.0.0
+_TAG_REVISION=23
 TERMUX_PKG_VERSION=${_TAG_VERSION}.${_TAG_REVISION}
 TERMUX_PKG_REVISION=18


I think it is proper for this line TERMUX_PKG_REVISION to be deleted because TERMUX_PKG_VERSION increased, is that correct? or is this package a special case (there are no other special cases as far as I know so if this package is one, I would also be interested to find out why)

robertkirkman · 2025-08-25T05:39:18Z

packages/aapt/build.sh

 termux_step_make() {
 	. $TERMUX_PKG_BUILDER_DIR/sources.sh

+	termux_setup_protobuf


Why is termux_setup_protobuf needed again here when it was already used during termux_step_pre_configure?

robertkirkman · 2025-08-25T05:41:53Z

packages/aapt/build.sh


 	termux_setup_protobuf

 	export PATH=$TERMUX_PKG_HOSTBUILD_DIR/_prefix/bin:$PATH


Isn't this line no longer necessary because there is no hostbuild-step in this package anymore, so this folder does not exist?

robertkirkman · 2025-08-25T05:42:53Z

packages/aapt/build.sh


 	termux_setup_protobuf

 	export PATH=$TERMUX_PKG_HOSTBUILD_DIR/_prefix/bin:$PATH


Also, a few lines above this line, there is a block

# Certain packages are not safe to build on device because their # build.sh script deletes specific files in $TERMUX_PREFIX. if $TERMUX_ON_DEVICE_BUILD; then termux_error_exit "Package '$TERMUX_PKG_NAME' is not safe for on-device builds." fi

This is outdated and this package is not unsafe for on-device build anymore. This is here because once, long ago, aapt used to use rm -rf $TERMUX_PREFIX/include/aosp during build.sh, but it doesn't anymore and things changed so that folder doesn't exist in any present-day Termux anymore.

robertkirkman · 2025-08-25T05:48:18Z

packages/aapt/build.sh

 TERMUX_PKG_MAINTAINER="@termux"
-_TAG_VERSION=13.0.0
-_TAG_REVISION=6
+_TAG_VERSION=15.0.0


Here is an additional patch you will need in order to successfully build this PR after the update to NDK r28c.

--- a/base/tools/aapt/ResourceTable.h +++ b/base/tools/aapt/ResourceTable.h @@ -20,6 +20,8 @@ class XMLNode; class ResourceTable; +#include "XMLNode.h" + enum { XML_COMPILE_STRIP_COMMENTS = 1<<0, XML_COMPILE_ASSIGN_ATTRIBUTE_IDS = 1<<1,

robertkirkman · 2025-08-25T05:48:45Z

I have noticed that this package actually is safe for attempting on-device builds because the block which disables on-device building in aapt is outdated and no longer correct, and I have found that it is possible to produce and test them using this series of commands, however, unfortunately, the aapt2 that results from my on-device building has a bug that is not present in the cross-compiled version. I will explain all details of what I have observed so far for the purpose of documentation.

pkg upgrade
termux-setup-storage
pkg install git wget gradle
pkg remove aapt aapt2 # remove preexising installations - IMPORTANT
git clone -b aapt_15_23 https://github.com/birhburh/termux-packages.git termux-packages-aapt-15-src
git clone https://github.com/termux/termux-packages.git termux-packages-aapt-15-dest
rm -rf termux-packages-aapt-15-dest/packages/aapt
cp -r termux-packages-aapt-15-src/packages/aapt termux-packages-aapt-15-dest/packages/
cd termux-packages-aapt-15-dest
sed -i -e '/if $TERMUX_ON_DEVICE_BUILD/,+3d' packages/aapt/build.sh
export TERMUX_PKG_TMPDIR=$PREFIX/tmp TERMUX_JAVA_HOME=$PREFIX/lib/jvm/java-21-openjdk
scripts/setup-android-sdk.sh
scripts/setup-termux.sh
./build-package.sh -I -f aapt
cd output
apt reinstall ./*.deb
cd ../..
mkdir -p ~/.gradle
echo "android.aapt2FromMavenOverride=$PREFIX/bin/aapt2" > ~/.gradle/gradle.properties
git clone https://github.com/Appliberated/HelloWorldSelfAware.git
. termux-packages-aapt-15-dest/scripts/properties.sh 
echo "sdk.dir=$ANDROID_HOME" > HelloWorldSelfAware/local.properties
cd HelloWorldSelfAware
gradle assembleDebug

However, this error happens, indicating that on-device builds of aapt2 are malformed (this doesn't happen with cross-compiled builds of the aapt2 .deb file that are copied from the cross-compiler device to the Termux device and installed)

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > AAPT2 bin Daemon #0: Unexpected error during link, attempting to stop daemon.
     This should not happen under normal circumstances, please file an issue if it does.

Unfortunately I do not know how to debug or fix that error but I wanted to post it here so that it is documented.

birhburh requested review from Grimler91 and TomJo2000 as code owners March 8, 2025 03:10

TomJo2000 reviewed Mar 8, 2025

View reviewed changes

birhburh force-pushed the aapt_15_23 branch from 9377a1b to 0fe2d39 Compare March 8, 2025 04:35

birhburh added 2 commits June 27, 2025 18:18

aapt: Bump to 15.0.0.23

a34ca6c

conforming to android-35

aapt2 segfaults for me now, but no linking errors

2cd8f14

birhburh force-pushed the aapt_15_23 branch from 0fe2d39 to f99abea Compare June 27, 2025 16:19

fix properties.cpp segfault for appt2

03383d0

birhburh force-pushed the aapt_15_23 branch from f99abea to 03383d0 Compare June 29, 2025 02:04

robertkirkman requested changes Aug 25, 2025

View reviewed changes

robertkirkman mentioned this pull request Oct 12, 2025

[Bug]: aapt2 can't include jars with -I #26858

Open


		termux_setup_protobuf

		export PATH=$TERMUX_PKG_HOSTBUILD_DIR/_prefix/bin:$PATH

Uh oh!

aapt: Bump to 15.0.0.23 #23671

Are you sure you want to change the base?

aapt: Bump to 15.0.0.23 #23671

Uh oh!

Conversation

birhburh commented Mar 8, 2025

Uh oh!

TomJo2000 left a comment

Choose a reason for hiding this comment

Uh oh!

birhburh commented Mar 8, 2025

Uh oh!

Biswa96 commented Mar 8, 2025

Uh oh!

birhburh commented Mar 8, 2025

Uh oh!

Biswa96 commented Mar 8, 2025

Uh oh!

MohammadKHC commented Mar 14, 2025

Uh oh!

birhburh commented Mar 14, 2025

Uh oh!

Anonymous2716 commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twaik commented Apr 18, 2025

Uh oh!

MohammadKHC commented May 14, 2025

Uh oh!

MohammadKHC commented May 22, 2025

Uh oh!

birhburh commented May 23, 2025

Uh oh!

birhburh commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

birhburh commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robertkirkman Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

robertkirkman Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

robertkirkman Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

robertkirkman Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

robertkirkman Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

robertkirkman Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

robertkirkman commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Anonymous2716 commented Mar 16, 2025 •

edited

Loading

birhburh commented May 24, 2025 •

edited

Loading

birhburh commented Jun 29, 2025 •

edited

Loading

robertkirkman commented Aug 25, 2025 •

edited

Loading