这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(scripts/lint-packages): use package directory for version diff check #26750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix(scripts/lint-packages): use package directory for version diff check #26750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions scripts/lint-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,19 @@ check_indentation() {
# - Modify TERMUX_PKG_VERSION
# - Or specify one of the CI skip tags
check_version_change() {
local base_commit commit_diff package="$1"
base_commit="$(git merge-base 'master@{upstream}' 'HEAD')"
commit_diff="$(git log --patch "${base_commit}.." -- "$package")"
local base_commit commit_diff package_dir="${1%/*}"
base_commit="$(< "$TERMUX_SCRIPTDIR/.git/refs/remotes/origin/master")"

[[ -z "$base_commit" ]] && {
echo
echo
echo "Couldn't determine base commit of branch."
echo "This shouldn't be able to happen..."
ls -AR "$TERMUX_SCRIPTDIR/.git/refs"
exit 1
} >&2

commit_diff="$(git log --patch "${base_commit}.." -- "$package_dir")"

# If the diff is empty there's no commit modifying that package on this branch, which is a PASS.
[[ -z "$commit_diff" ]] && return
Expand Down Expand Up @@ -240,7 +250,7 @@ lint_package() {
echo
echo "Version of '$package_name' has not changed."
echo "Either 'TERMUX_PKG_REVISION' or 'TERMUX_PKG_VERSION'"
echo "need to be modified when changing a package build."
echo "need to be modified in the build.sh when changing a package build."
echo "Alternatively you can add '[no version check]'."
echo "To the commit message to skip this check."
echo
Expand Down