-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Move libusb to termux-root-packages #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In order to use this library to actually access USB on your Android device, would the Termux app need extra permissions? |
|
So should we move this to root-packages? |
|
Probably |
|
Ok I will try now |
|
Do we need two PRs for the same package? |
|
Oh, okay 😅 |
|
Wouldn't libusb still be useful for compiling packages requiring libusb? |
|
Then won’t those packages also require root access? |
|
@Wetitpig yeah, those packages would require root, trying to use them would otherwise give "permission denied" error or similar. Libusb however is just a library and won't ever give you "permission denied" error. |
|
@Grimler91 Is there a function that can run without root in the library? |
|
@Wetitpig libusb is a |
|
I think the libraries should be in |
|
@Auxilus @Grimler91 Install never requires root. It’s only using it that requires root. The main point should be whether it can function without root. |
|
@Wetitpig then it depends on how we define "to function", I see it as that libusb's function is to enable other packages to be linked to it with |
|
So not ALL programs linked with libusb require root? |
|
Otherwise, it is quite useless to keep the library only while it cannot compile any packages that do not need root. |
|
Libusb is now available from the root repo so this can be merged. |
I have built libusb for all 4 arches and I cannot find any errors. I don't see why do we put them in the disabled-packages section.
Attached is the log for the build of libusb for all 4 arches.
Thanks!