这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Wetitpig
Copy link
Contributor

I have built libusb for all 4 arches and I cannot find any errors. I don't see why do we put them in the disabled-packages section.

Attached is the log for the build of libusb for all 4 arches.

Thanks!

@joakim-noah joakim-noah mentioned this pull request Feb 21, 2018
@joakim-noah
Copy link
Contributor

In order to use this library to actually access USB on your Android device, would the Termux app need extra permissions?

@Wetitpig
Copy link
Contributor Author

So should we move this to root-packages?

@tomty89
Copy link
Contributor

tomty89 commented Feb 21, 2018

Probably

$ /system/bin/lsusb
lsusb: No /sys/bus/usb/devices/: Permission denied
$

@Wetitpig
Copy link
Contributor Author

Ok I will try now

@Auxilus
Copy link
Contributor

Auxilus commented Feb 21, 2018

Do we need two PRs for the same package?

@Wetitpig
Copy link
Contributor Author

Wetitpig commented Feb 21, 2018

The #1715 is for adding the package, #2175 is for removing from this repo

@Wetitpig Wetitpig changed the title Move libusb to packages Move libusb to termux-root-packages Feb 21, 2018
@Auxilus
Copy link
Contributor

Auxilus commented Feb 21, 2018

Oh, okay 😅

@Grimler91
Copy link
Member

Wouldn't libusb still be useful for compiling packages requiring libusb?
Those packages wouldn't work without root however, as you've discussed.
I guess it depends on how we draw the line between termux-packages and termux-root-packages.

@Wetitpig
Copy link
Contributor Author

Then won’t those packages also require root access?

@Grimler91
Copy link
Member

@Wetitpig yeah, those packages would require root, trying to use them would otherwise give "permission denied" error or similar. Libusb however is just a library and won't ever give you "permission denied" error.

@Wetitpig
Copy link
Contributor Author

@Grimler91 Is there a function that can run without root in the library?

@Auxilus
Copy link
Contributor

Auxilus commented Feb 22, 2018

@Wetitpig libusb is a library it's not a front end package, so it doesn't require root to install, like @Grimler91 said it depends on how we draw the line between termux-packages and termux-root-packages

@Auxilus
Copy link
Contributor

Auxilus commented Feb 22, 2018

I think the libraries should be in termux-packages

@Wetitpig
Copy link
Contributor Author

@Auxilus @Grimler91 Install never requires root. It’s only using it that requires root. The main point should be whether it can function without root.

@Grimler91
Copy link
Member

@Wetitpig then it depends on how we define "to function", I see it as that libusb's function is to enable other packages to be linked to it with -lusb, this will work without errors.
Those other packages would require root to function though (currently, termux-api can include usb functionality in the future).

@Wetitpig
Copy link
Contributor Author

So not ALL programs linked with libusb require root?

@Wetitpig
Copy link
Contributor Author

Wetitpig commented Feb 27, 2018

Otherwise, it is quite useless to keep the library only while it cannot compile any packages that do not need root.

@Grimler91
Copy link
Member

Libusb is now available from the root repo so this can be merged.

@fornwall fornwall merged commit fb0734d into termux:master Sep 15, 2018
@Wetitpig Wetitpig deleted the libusb branch January 23, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants