这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Maxython
Copy link
Member

#10256

So far only done for generate-bootstraps.sh. Already tested everything, it works fine. I'll work on improving build-bootstraps.sh later.

@Maxython
Copy link
Member Author

Maxython commented Apr 24, 2022

Unfortunately I can't do development to build-bootstraps.sh. I think it would be right to make these requests for consideration, and create them separately for build-bootstraps.sh.

@Maxython Maxython changed the title Updated scripts for creating bootstrap generate-bootstraps.sh: adding a way to generate bootstrap based on pacman Apr 24, 2022
@Maxython Maxython marked this pull request as ready for review April 24, 2022 21:19
@Maxython Maxython requested a review from Grimler91 as a code owner April 24, 2022 21:19
@Maxython
Copy link
Member Author

@agnostic-apollo

@agnostic-apollo
Copy link
Member

Otherwise looks fine from a quick overview. For pacman issues, you would need to solve yourself since I am not familiar with it or its build system.

Unfortunately I can't do development to build-bootstraps.sh.

Yeah, not a necessity. Up to you and other pacman users.

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Apr 27, 2022

Can you allow edits from maintainers?

@Maxython
Copy link
Member Author

Can you allow edits from maintainers?

That is, to allow you to edit the file?
A little, I did not understand your question.

@agnostic-apollo
Copy link
Member

Yeah, there should be an option in the side bar of the pull request for you.

@Maxython
Copy link
Member Author

Yeah, there should be an option in the side bar of the pull request for you.

I don't have that option.

@Grimler91
Copy link
Member

@agnostic-apollo I think you should have access, normally we are able to force push to the remote branch (termux-pacman:bootstraps in this case) in the PR, unless the branch is protected or something in the other repo

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Apr 27, 2022

I am getting

ERROR: Permission to termux-pacman/termux-packages.git denied to agnostic-apollo.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights

Access is granted with Allow edits from maintainers toggle when you a create pull request or after that too. But since termux-pacman is an organization and not a user account, that toggle won't exist.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Anyways, undo your last commit with git reset --hard HEAD^ and apply patch with git am < git.txt and force push.

git.txt

@Grimler91
Copy link
Member

Yeah, you are right, same issue in #10359

@Maxython
Copy link
Member Author

@agnostic-apollo thank you.

I will probably give you access to the termux-packages repo so that this situation does not happen again.

…age manager and work with db from the pacman service.
@agnostic-apollo agnostic-apollo merged commit b989729 into termux:master Apr 27, 2022
@agnostic-apollo
Copy link
Member

You are welcome and thanks to you too.

That can be done, although not currently necessary. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants