android-tools: fix typos in fastboot patch #10359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ookiineko <chiisaineko@protonmail.com>
Member
|
Thanks, merged: 67ceadb (seems like I can't edit the PR due to it not originating from your username, not because of master branch/protected branches) |
Author
Thank you sir! It's finally working now! Screenshots |
|
termux-usb support added in adb? |
Author
not yet, maybe u can give a try? |
|
I have finally found a way to patch the adb binary to add support for USB devices for non-rooted users using the Termux-USB API. This means that you no longer need to run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am really sorry about this...
Basically I shouldn't use
ANDROIDcompiler option...vanilla NDK doesn't have it,
I was passing
-DANDROID=1to the CMake in my local test env, so I didn't realize it until just now..__ANDROID__is the correct one, this will fix my typos in the last PR #10339Luckily this didn't break anything else, rooted users are still able to use fastboot normally
just Termux-usb support was not included.. (due to the wrong compiler option)
now I've comfirmed it is working
Screenshot
please blame it on me..