这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@brubakerjeff
Copy link

In order to handle Raspberry PI I made the onDraw routing more generic by calling the drawColor each time.

After the change I found termux to function correctly on a Raspberry PI and still functioned correctly on the Android 8.1 emulators I tried for regression test.

@Grimler91
Copy link
Member

And for future reference: this fixes #912

Copy link
Author

@brubakerjeff brubakerjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good feedback!

@brubakerjeff
Copy link
Author

Can this be merged?

@RHerasymenko
Copy link

Need this functionality as well. Any update on this?

@brubakerjeff
Copy link
Author

brubakerjeff commented Feb 12, 2019 via email

@RHerasymenko
Copy link

I had done a pull request, don’t think it is merged yet

On Tue, Feb 12, 2019 at 3:32 PM RHerasymenko @.***> wrote: Need this functionality as well. Any update on this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#919 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AGPPbsJ2-MNAxTJe9Qb1HtMuQ8vxy8gEks5vMyTvgaJpZM4YfCB_ .

I know, it's more a question to maintainers ...

@brubakerjeff
Copy link
Author

brubakerjeff commented Feb 12, 2019 via email

@brubakerjeff
Copy link
Author

@fornwall any chance we can move on this?

@fornwall
Copy link
Member

@brubakerjeff Sorry for the delay here.

The main argument against merging this PR was that the current behaviour (to avoid drawing the background if not necessary) is actually intended, to avoid overdraw (https://www.youtube.com/watch?v=T52v50r-JfE) for performance and battery efficiency.

So AFAIK this change would be a workaround for broken graphics behaviour/driver for android on raspberry pi. Or do we believe the current code to be wrong?

With that said, I haven't actually measured if the overdraw avoidance actually improves efficiency in any meaningful way, I just looked at the android developer option and visually determined that overdraw was avoided.

@brubakerjeff Can you re-check with the latest available Android version/build for the device and see if the system behaviour has improved (is this still necessary)?

@brubakerjeff
Copy link
Author

Thank you. I will add it to my list to try to with the new version. No worries for backlog, glad there was follow through. I wish we could get a google android things developer (does anyone know any) on here to be more authoritative for the "workaround" statement. Understandably if this is perceived as a workaround a fix at the root is perceived as more advantageous.

@finagolfin
Copy link
Member

Ping, still needed?

@thunder-coding
Copy link
Member

Ping 2, is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants