-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Updated terminalview.ondraw to be more generic for Raspberry Pi 3 B with Android 1.0.6 #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
And for future reference: this fixes #912 |
brubakerjeff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good feedback!
|
Can this be merged? |
|
Need this functionality as well. Any update on this? |
|
I had done a pull request, don’t think it is merged yet
…On Tue, Feb 12, 2019 at 3:32 PM RHerasymenko ***@***.***> wrote:
Need this functionality as well. Any update on this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#919 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGPPbsJ2-MNAxTJe9Qb1HtMuQ8vxy8gEks5vMyTvgaJpZM4YfCB_>
.
|
I know, it's more a question to maintainers ... |
|
“Likes” yes there is a small community from my end too that could use it
On Tue, Feb 12, 2019 at 3:35 PM RHerasymenko <notifications@github.com>
wrote:
… I had done a pull request, don’t think it is merged yet
… <#m_1931700683933607850_>
On Tue, Feb 12, 2019 at 3:32 PM RHerasymenko ***@***.***> wrote: Need this
functionality as well. Any update on this? — You are receiving this because
you authored the thread. Reply to this email directly, view it on GitHub <#919
(comment)
<#919 (comment)>>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGPPbsJ2-MNAxTJe9Qb1HtMuQ8vxy8gEks5vMyTvgaJpZM4YfCB_
.
I know, it's more a question to maintainers ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#919 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGPPblUKV85bx0cuZYTzZ73P4lzPCoKAks5vMyWSgaJpZM4YfCB_>
.
|
|
@fornwall any chance we can move on this? |
|
@brubakerjeff Sorry for the delay here. The main argument against merging this PR was that the current behaviour (to avoid drawing the background if not necessary) is actually intended, to avoid overdraw (https://www.youtube.com/watch?v=T52v50r-JfE) for performance and battery efficiency. So AFAIK this change would be a workaround for broken graphics behaviour/driver for android on raspberry pi. Or do we believe the current code to be wrong? With that said, I haven't actually measured if the overdraw avoidance actually improves efficiency in any meaningful way, I just looked at the android developer option and visually determined that overdraw was avoided. @brubakerjeff Can you re-check with the latest available Android version/build for the device and see if the system behaviour has improved (is this still necessary)? |
|
Thank you. I will add it to my list to try to with the new version. No worries for backlog, glad there was follow through. I wish we could get a google android things developer (does anyone know any) on here to be more authoritative for the "workaround" statement. Understandably if this is perceived as a workaround a fix at the root is perceived as more advantageous. |
|
Ping, still needed? |
|
Ping 2, is this still needed? |
105a19a to
b950efe
Compare
21804bc to
3f7a939
Compare
In order to handle Raspberry PI I made the onDraw routing more generic by calling the drawColor each time.
After the change I found termux to function correctly on a Raspberry PI and still functioned correctly on the Android 8.1 emulators I tried for regression test.