-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Usable Termux project for latest Android Studio + Compilable and usable same as old one #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
benja2998
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing dependencies may break the app.
|
Sir, I have tested the app already on a Xiaomi Android 15 device, it worked smooth and same as old version but that time the application color of the logo worked since it existed configs about it. I tryed to change the andorid sdk versions but it broke so I let them as it is. |
Older Android versions may not have the new versions of these dependencies. Use the Android Stuido emulator to test older Androd versions. |
twaik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also squash your commits please.
| WebSettings settings = mWebView.getSettings(); | ||
| settings.setCacheMode(WebSettings.LOAD_NO_CACHE); | ||
| settings.setAppCacheEnabled(false); | ||
| //settings.setAppCacheEnabled(false); // uh? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
| task sourceJar(type: Jar) { | ||
| from android.sourceSets.main.java.srcDirs | ||
| classifier "sources" | ||
| //classifier "sources" //depracated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| //classifier "sources" //depracated | |
| // classifier parameter is deprecated | |
| `` |
|
This won't be merged so no need to spend time on it. These issues have already been fixed locally and will be available in coming days. The only thing that's needed for latest android studio version to build termux-app is using jdk 11 or 17 instead of default 21. |
Usable Termux project for latest Android Studio + Compilable and usable same as old one, this comits will let the project being able to be updated even later on. This may be uselfull.