这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Comical78
Copy link

Usable Termux project for latest Android Studio + Compilable and usable same as old one, this comits will let the project being able to be updated even later on. This may be uselfull.

@Comical78 Comical78 requested a review from benja2998 April 8, 2025 05:34
Copy link

@benja2998 benja2998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing dependencies may break the app.

@Comical78
Copy link
Author

Sir, I have tested the app already on a Xiaomi Android 15 device, it worked smooth and same as old version but that time the application color of the logo worked since it existed configs about it. I tryed to change the andorid sdk versions but it broke so I let them as it is.

@benja2998
Copy link

Sir, I have tested the app already on a Xiaomi Android 15 device, it worked smooth and same as old version but that time the application color of the logo worked since it existed configs about it. I tryed to change the andorid sdk versions but it broke so I let them as it is.

Older Android versions may not have the new versions of these dependencies. Use the Android Stuido emulator to test older Androd versions.

Copy link
Member

@twaik twaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also squash your commits please.

WebSettings settings = mWebView.getSettings();
settings.setCacheMode(WebSettings.LOAD_NO_CACHE);
settings.setAppCacheEnabled(false);
//settings.setAppCacheEnabled(false); // uh?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

task sourceJar(type: Jar) {
from android.sourceSets.main.java.srcDirs
classifier "sources"
//classifier "sources" //depracated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//classifier "sources" //depracated
// classifier parameter is deprecated
``

@agnostic-apollo
Copy link
Member

This won't be merged so no need to spend time on it. These issues have already been fixed locally and will be available in coming days.

The only thing that's needed for latest android studio version to build termux-app is using jdk 11 or 17 instead of default 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants