-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Begin conversion to Kotlin #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I simply bumped the gradle version to 4.0.0
RebelTat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's well thought out
|
While Kotlin is better, this app isn't updated much, so I don't think it's worth the effort of a rewrite. |
donno2048
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kotlin is better but does it really worth it?
|
What do you think @agnostic-apollo should we upgrade to kotlin? |
|
Sure, why not. Don't let my never having coded in Kotlin stop this movement. It would just mean my termux contributions stopping for who knows how long :p And not much code anyways... Specially no complex terminal code. |
|
I think if you stop contributing, the activity here might die, as you are the most active keeping the app |
|
On a more serious note, I am not totally against the conversion to kotlin despite me not knowing the language currently. It could be done eventually, at least parts of it. Currently, as I said, I don't know the language and if not me, other termux maintainers would still need to know the language deeply to actually rewrite so that the app improves and doesn't get filled with bad design or bugs just for the sake of conversion. If outside contributor rewrites the app but the main maintainers don't know the language, then that it also an issue. How would they review, maintain and update, if they don't understand the lang. I don't know the status of other maintainer's kotlin knowledge. Moreover, there are lot of issues pending that are far more important to spend time on than language conversion. The users may not notice much change anyways for many if not most things. The There are still more java devs than kotlin devs, so higher chance of contributions from others too. Java also would have much better language support (tutorials, etc). I'll eventually need to learn it, but may not be soon. |
|
So, do we agree to keep it in java? |
|
For now, yes |
|
Ok, then close the PR |
We've (@larson-carter) configured Kotlin for the app and converted the
BellUtilfrom Java to Kotlin.What do you think?