这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@bartekpacia
Copy link

We've (@larson-carter) configured Kotlin for the app and converted the BellUtil from Java to Kotlin.

What do you think?

Larson Carter and others added 3 commits June 15, 2020 10:49
@bartekpacia bartekpacia changed the title Started converstion to Kotlin Begin conversion to Kotlin Jun 16, 2020
@ghost ghost requested a review from fornwall July 4, 2020 12:32
Copy link

@RebelTat RebelTat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's well thought out

@finagolfin
Copy link
Member

While Kotlin is better, this app isn't updated much, so I don't think it's worth the effort of a rewrite.

Copy link

@donno2048 donno2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin is better but does it really worth it?

@hisirdox
Copy link
Contributor

What do you think @agnostic-apollo should we upgrade to kotlin?

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Mar 30, 2022

Sure, why not. Don't let my never having coded in Kotlin stop this movement. It would just mean my termux contributions stopping for who knows how long :p

And not much code anyways... Specially no complex terminal code.

( find ./ -name '*.java' -print0 | xargs -0 cat ) | wc -l
38518

@hisirdox
Copy link
Contributor

I think if you stop contributing, the activity here might die, as you are the most active keeping the app

@agnostic-apollo
Copy link
Member

On a more serious note, I am not totally against the conversion to kotlin despite me not knowing the language currently.

It could be done eventually, at least parts of it. Currently, as I said, I don't know the language and if not me, other termux maintainers would still need to know the language deeply to actually rewrite so that the app improves and doesn't get filled with bad design or bugs just for the sake of conversion. If outside contributor rewrites the app but the main maintainers don't know the language, then that it also an issue. How would they review, maintain and update, if they don't understand the lang. I don't know the status of other maintainer's kotlin knowledge.

Moreover, there are lot of issues pending that are far more important to spend time on than language conversion. The users may not notice much change anyways for many if not most things.

The terminal-view and terminal-emulator code is quite complex and I don't understand much of it and I haven't tried to understand either, but it would probably takes weeks or months of research, so can't really rewrite something you don't understand fully.

There are still more java devs than kotlin devs, so higher chance of contributions from others too. Java also would have much better language support (tutorials, etc).

I'll eventually need to learn it, but may not be soon.

@hisirdox
Copy link
Contributor

hisirdox commented Apr 2, 2022

So, do we agree to keep it in java?
Maybe close this PR then...

@agnostic-apollo
Copy link
Member

For now, yes

@hisirdox
Copy link
Contributor

hisirdox commented Apr 2, 2022

Ok, then close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants