coverity scan to Master #1498
Closed
coverity scan to Master #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icons used in notifications/status bar are monochrome and should use only white color and transparency. It is displayed fine on Android emulators but it's shown in black on Samsung Galaxy S7 running Android 7.0. After the change, status bar icon is white and the small icon in notification still uses the black color set via setColor(). Termux doesn't support devices running Android older than 5.0 but using white color in vector drawables would be also necessary to generate proper (white) bitmap icons.
I want to use the renderer with a custom canvas without having to render to an Android View which requires a context and all sorts of stuff. Can't currently do that because the renderer is package-private
The Google-Repository is required for compilation because some dependencies were removed from jcenter()
Termux will now properly send \r to the terminal instead of \n when pasting multiline strings. This fixes cat not repeating back lines and nano accidentally justifying text (because \n maps to ^J), as well as other potential issues. This matches the behavior of other terminals, such as iTerm2 which explicitly does it here: https://github.com/gnachman/iTerm2/blob/f8a5930/sources/iTermPasteHelper.m#L113 Signed-off-by: easyaspi314 (Devin) <easyaspi314@users.noreply.github.com>
This should replace both \r\n and \n with \r now. "\r?\n" matches 0 or 1 \r and one \n, which should capture both escape sequences.
This commit adds an optional final argument to the BackgroundJob constructor for a PendingIntent to return the results of its execution to, and also attempts to pass an optional pendingIntent to it from the Service start intent
This mimics the behaviour of most tabbed terminal emulators. Fixes termux#1009.
Use volume-keys=volume within termux.properties to disable.
v19 had a problem with metadata which broke the package manager.
A file is deletable if the _parent_ is writable, not the file itself.
Fixing CI builds.
|
This changeset is really unacceptable. Have you looked at conflicts at all ? |
|
Maybe better to merge coverity scan into master branch and not vice versa ? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
29 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding coverity scanning to master