Fix for #572: merge ~/storage instead of del #578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could recursively delete, as in the method above, but that would require a separate try block for a separate logcat message, or a different method that returns a flag. I prefer merging in case of custom folders. Another alternative may be to send an exit code or something for the termux-setup-storage script to detect and echo an error message.
Contributor
Author
|
To merge effectively, we'd probably need checks for each existing symlink, as well. |
Contributor
Author
|
Travis is set up on my fork, now, so I'll close this for the time being. |
Quasic
added a commit
to Quasic/termux-app
that referenced
this pull request
Feb 6, 2018
AdamMickiewich
pushed a commit
to VolyaTeam/dzida-app
that referenced
this pull request
Aug 8, 2022
contourintegrals
pushed a commit
to reisxd/termux-app
that referenced
this pull request
Oct 20, 2022
frikke
pushed a commit
to frikke/termux-app
that referenced
this pull request
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could recursively delete, as in the method above, but that would
require a separate try block for a separate logcat message, or a
different method that returns a flag. I prefer merging in case of custom
folders. Another alternative may be to send an exit code or something for
the termux-setup-storage script to detect and echo an error message.