Weather Module #79
Closed
Weather Module #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JOKES_SOURCE_FILE = 'data/jokes.json' | ||
| MAPQUEST_CONSUMER_KEY = '<MAPQUEST_CONSUMER_KEY>' | ||
| TIME_ZONE_DB_API_KEY = '<TIME_ZONE_DB_API_KEY>' | ||
| OPEN_WEATHER_MAP_ACCESS_TOKEN = '7af6de37fc4d3517129290b740663142' |
Contributor
There was a problem hiding this comment.
I don't think having your access token in a config file is a good idea.
Contributor
Author
There was a problem hiding this comment.
It's a trash account anyways, just proof that it works:)
Contributor
Author
|
@swapagarwal Just been added to the testing list and the bot is better than I first expected. Super cool work man, and I'm so glad you've made it available to people like me! I've just ran some local tests with my last commit and seems to be working good:) |
Owner
|
Glad you like it! |
swapagarwal
added a commit
that referenced
this pull request
Jun 10, 2016
Squashed commit of the following:
commit 7ac926233268a58c9dbb222f5dffa551360700db
Author: Swapnil Agarwal <swapnilagarwal@live.com>
Date: Fri Jun 10 06:29:58 2016 +0000
Fix merge conflicts
Owner
|
Merged in 7fd41a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry again about new pr, same reason - my last fork was a mess. No DS_store this time and fixed array error.