这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shnupta
Copy link
Contributor

@shnupta shnupta commented Jun 7, 2016

So I've adapted the original p #28 r and got an account on openweathermap to use the api key. I think, the intents need to be added on wit.ai but I'm not sure. Info on this? It's one of my first proper contributions to a project!

@swapagarwal
Copy link
Owner

@williamshoops96 Welcome to the world of open-source. Your PR looks quite good for a first contribution! 😄
The intents are already set up, that's why it passed the tests.
Just take a look at the lines I've commented on and this should be ready to merge!

@swapagarwal swapagarwal mentioned this pull request Jun 8, 2016
@swapagarwal
Copy link
Owner

swapagarwal commented Jun 8, 2016

Remove all the .DS_Store files. There should be changes in 4 files only: https://github.com/swapagarwal/JARVIS-on-Messenger/pull/76/files

'request',
'time',
'wiki',
'weather',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical

@shnupta
Copy link
Contributor Author

shnupta commented Jun 8, 2016

Thank you haha! Program a lot, just trying to become better by
contributing! Okay I'll take a look later. I'm in school at the moment.
On 8 Jun 2016 9:16 a.m., "Swapnil Agarwal" notifications@github.com wrote:

@williamshoops96 https://github.com/williamshoops96 Welcome to the
world of open-source. Your PR looks quite good for a first contribution!
😄
The intents are already set up, that's why it passed the tests.
Just take a look at the lines I've commented on and this should be ready
to merge!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#76 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/APup3-1K6sd3DdMEeduRXQZoRWrbwHQNks5qJnpAgaJpZM4IwSAh
.

@shnupta
Copy link
Contributor Author

shnupta commented Jun 8, 2016 via email

'time',
'weather',
'wiki',

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

@swapagarwal
Copy link
Owner

Maybe this can be of help: https://jonbellah.com/recursively-remove-ds-store/
TL;DR: find . -name '*.DS_Store' -type f -delete

@shnupta
Copy link
Contributor Author

shnupta commented Jun 8, 2016

Ah thanks. Will make it a lot faster!
On 8 Jun 2016 10:37 a.m., "Swapnil Agarwal" notifications@github.com
wrote:

Maybe this can be of help:
https://jonbellah.com/recursively-remove-ds-store/
TL;DR: find . -name '*.DS_Store' -type f -delete


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#76 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/APup3_sxu1JYfJUbeC2dgpHZFl7szG_Dks5qJo1ogaJpZM4IwSAh
.

@shnupta
Copy link
Contributor Author

shnupta commented Jun 8, 2016

reference #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants