这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MetcalfeTom
Copy link
Contributor

This PR re-enables the vibekit grok command. Support for this agent appears to have been removed during a previous refactor, and this change restores the agent wrapper, CLI command, and all related documentation.

This change is dependent on an upstream fix in the @vibe-kit/grok-cli repository to resolve a runtime error.

Related PR: superagent-ai/grok-cli#77

Checklist
[x] I tested my changes
[x] I reviewed my own code

@vercel
Copy link

vercel bot commented Sep 8, 2025

@MetcalfeTom is attempting to deploy a commit to the Superagent Team on Vercel.

A member of the Team first needs to authorize it.

@homanp
Copy link
Collaborator

homanp commented Sep 8, 2025

@MetcalfeTom thank you for the PR will get it merged

@homanp
Copy link
Collaborator

homanp commented Sep 12, 2025

@MetcalfeTom I guess we can add this now?

@MetcalfeTom
Copy link
Contributor Author

@homanp Seems not, there was a subsequent upstream change which caused another dependency issue :(

It seems that ink is importing an ES module yoga-layout in grok which causes an incompatibility when running with the other CommonJS modules in vibekit

I can take another stab at this, do you have any thoughts on a solution?

@homanp
Copy link
Collaborator

homanp commented Sep 12, 2025

@homanp Seems not, there was a subsequent upstream change which caused another dependency issue :(

It seems that ink is importing an ES module yoga-layout in grok which causes an incompatibility when running with the other CommonJS modules in vibekit

I can take another stab at this, do you have any thoughts on a solution?

hmm, not sure. have to look into it as well.

@MetcalfeTom
Copy link
Contributor Author

@homanp I can build the vibekit docker image by either:

  1. converting the vibekit image to use node and npm
  2. converting grok-cli to use bun and ES2022

🎉

My guess is that number 2 is the better option to match the ts configuration here. Would you be open to build with bun in grok-cli?

@homanp
Copy link
Collaborator

homanp commented Sep 13, 2025

@homanp I can build the vibekit docker image by either:

  1. converting the vibekit image to use node and npm

  2. converting grok-cli to use bun and ES2022

🎉

My guess is that number 2 is the better option to match the ts configuration here. Would you be open to build with bun in grok-cli?

Option 2 works!

@MetcalfeTom
Copy link
Contributor Author

@homanp ready! 👉 superagent-ai/grok-cli#78

@homanp
Copy link
Collaborator

homanp commented Sep 13, 2025

@homanp ready! 👉 superagent-ai/grok-cli#78

I merged and published a new version

Copy link
Collaborator

@homanp homanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would you mind adding a grok.test.ts as well to the /test folder? It can be similar to claude.test.ts

@MetcalfeTom
Copy link
Contributor Author

@homanp there is already a test on main, I guess it wasn't removed

https://github.com/superagent-ai/vibekit/blob/main/test%2Fgrok.test.ts

@homanp homanp merged commit ab7bd6b into superagent-ai:main Sep 13, 2025
2 of 5 checks passed
@homanp
Copy link
Collaborator

homanp commented Sep 13, 2025

@MetcalfeTom new versions of cli and sdk packages have been deployed. so this should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants