这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MetcalfeTom
Copy link
Contributor

@MetcalfeTom MetcalfeTom commented Sep 8, 2025

What does this PR do?

Fixes a runtime crash that prevented grok-cli from being integrated into vibekit. The application was failing on startup due to outdated UI library (inkmarkdown)

The error was:

 node packages/cli/dist/cli.js grok

🖖 VibeKit | Sandbox: ON (docker)

48 |       }
49 |     }Module["arguments"] = process["argv"].slice(2);if (typeof module !== "undefined") {
50 |       module["exports"] = Module;
51 |     }process["on"]("uncaughtException", function (ex) {
52 |       if (!(ex instanceof ExitStatus)) {
53 |         throw ex;
                   ^
TypeError: require() async module "/home/.bun/install/global/node_modules/ink/build/index.js" is unsupported. use "await import()" instead.
      at <anonymous> (/home/.bun/install/global/node_modules/yoga-layout-prebuilt/yoga-layout/build/Release/nbind.js:53:15)

Changes made:

  • Upgraded React from v17.0.2 to v18.3.1
  • Upgraded @types/react from v17.0.0 to v18.3.3
  • Upgraded TypeScript from v4.9.5 to v5.3.3
  • Removed incompatible ink-markdown dependency
  • Updated MarkdownRenderer to use marked-terminal

Related to upstream vibekit PR.

Fixes #

Checklist

  • I tested my changes
  • I reviewed my own code

@MetcalfeTom
Copy link
Contributor Author

Regarding the markdown, I've replaced with marked-terminal which seems to function the same.

Comparison: main on left and this branch on right:

Screenshot 2025-09-08 at 2 18 56 PM

@MetcalfeTom
Copy link
Contributor Author

@homanp could you approve the build trigger? Thanks!

@homanp
Copy link
Contributor

homanp commented Sep 12, 2025

Looks great!

@homanp
Copy link
Contributor

homanp commented Sep 12, 2025

@MetcalfeTom 'ind fixing the conflicts with main?

@MetcalfeTom
Copy link
Contributor Author

@homanp done! And tested

@homanp homanp merged commit bd78e9e into superagent-ai:main Sep 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants