这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@mvines
Copy link
Contributor

@mvines mvines commented Oct 29, 2018

  1. support macOS
  2. tune verbosity flag
  3. ignore build products

@mvines mvines requested a review from jackcmay October 29, 2018 15:59
@mvines mvines merged commit f295eb0 into solana-labs:v0.10 Oct 29, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
* token-swap: Fix withdrawal all tokens slippage

When withdrawing, the slippage check is done before `min`ing the token a
and b amounts, which makes it possible to ignore the desired slippage,
and lose out on a lot more than expected.

This has an additional knock-on effect. When burning all of the pool
tokens, it becomes impossible to ever use it again.

* Check for slippage after getting the actual amount that would be
  traded
* Re-initialize the pool token amount on the next deposit if all pool
  tokens were burned

Fixes solana-labs#1629

* Fmt + clippy

* Deposit one side on 0 pool tokens just gives new supply back
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants