This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Increase rmem and wmem for remote nodes in testnet (#1635) #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
pushed a commit
to mvines/solana
that referenced
this pull request
Oct 30, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* token-swap: Fix withdrawal all tokens slippage When withdrawing, the slippage check is done before `min`ing the token a and b amounts, which makes it possible to ignore the desired slippage, and lose out on a lot more than expected. This has an additional knock-on effect. When burning all of the pool tokens, it becomes impossible to ever use it again. * Check for slippage after getting the actual amount that would be traded * Re-initialize the pool token amount on the next deposit if all pool tokens were burned Fixes solana-labs#1629 * Fmt + clippy * Deposit one side on 0 pool tokens just gives new supply back
steviez
pushed a commit
to steviez/solana
that referenced
this pull request
Jun 14, 2024
* rpc: add tpu_forwards/tpu_forwards_quic to getClusterNodes * add tvu * order * add tpu_vote * add serve_repair * fix tests * fix name in tests * remove tvu / repair quic
gregcusack
pushed a commit
to gregcusack/solana
that referenced
this pull request
Jun 14, 2024
* rpc: add tpu_forwards/tpu_forwards_quic to getClusterNodes * add tvu * order * add tpu_vote * add serve_repair * fix tests * fix name in tests * remove tvu / repair quic
willhickey
pushed a commit
that referenced
this pull request
Aug 31, 2024
…2164) rpc: add more services to getClusterNodes (#1637) * rpc: add tpu_forwards/tpu_forwards_quic to getClusterNodes * add tvu * order * add tpu_vote * add serve_repair * fix tests * fix name in tests * remove tvu / repair quic (cherry picked from commit dbea20b) Co-authored-by: Kirill Fomichev <fanatid@ya.ru>
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Oct 10, 2024
…labs#1637) (solana-labs#2164) rpc: add more services to getClusterNodes (solana-labs#1637) * rpc: add tpu_forwards/tpu_forwards_quic to getClusterNodes * add tvu * order * add tpu_vote * add serve_repair * fix tests * fix name in tests * remove tvu / repair quic (cherry picked from commit dbea20b) Co-authored-by: Kirill Fomichev <fanatid@ya.ru>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Testnet nodes are dropping IP packets in kernel due to rcvbuf_errors. This causes packet loss and more repair requests.
Summary of Changes
Increase rmem and wmem for the remote nodes.
Fixes #
Cherry-pick from master