feat: migrate away from deprecated k8s@home and add automatic redis #3
Conversation
…eployment Signed-off-by: AltF2 <contact@altf2.dev>
| version: 0.2.2 | ||
| repository: https://charts.pascaliske.dev | ||
| condition: redis.enabled | ||
| condition: searxng.server.limiter |
There was a problem hiding this comment.
why changing this condition? what about backward compatibility?
| --- | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| kind: ConfigMap |
There was a problem hiding this comment.
The searx config may include some credentials so I don't understand why you changed that to a configmap.
|
The chart library is not going away anytime soon, so I don't see the point of removing the dependency on it. It's a great helm base, and probably a lot of people are using the features of this base chart for the SearXNG helm chart. See k8s-at-home/charts#1761 for more info. So I'm not going to remove this dependency. But we can switch to the new home for the library base helm chart: https://github.com/bjw-s/helm-charts/tree/main/charts/library/common |
|
These should probably be two separate PRs -- One for bringing the common library up to latest, and then another for adding in the redis dependency. Debugging failures will be harder without splitting up the changesets. |
|
This helm chart base is also interesting: https://github.com/stakater/application and it's being developed by a company, not by individual volunteers. |
|
Closing due to #3 (comment) |
No description provided.