-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[mod] fc_install: font config installer for the nerd-fonts #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6a76c98 to
cc00577
Compare
|
Thanks for the PR, it looks very good! Well, Im only on my phone right now and can not really examine. Iirc we have MIT license for all scripts, that simple "rule" would break with the license you choose. Second I do not get the dependency on fc-cache. I didnt encounter a system that needs a fc-cache call for years. And third ;-) apple has this bash 3 only, i would tweak the script to avoid the newer features. But, whatever, great work! |
Sorry for my ignorance about .. changed lic to MIT --> diff
fc-cache itself might not be needed, but the existence of this command ensures that a fontconfig freedesktop.org infrastructure (desktop vs. server distros) is installed .. if you insist, I can remove the use of
This script is written for Linux distros with a fontconfig freedesktop.org installation. I sorted out my last Mac OS systems many years ago, but I suspect:
Homebrew is the (missing/unofficially) package manager for Mac-OS and has a package for a updated version of |
|
To clarify: Installation scripts like the one in this PR do not replace a package manager; for example, this script does not offer automated updates (only manually or via a crontab entry). Nerd Fonts should be installed (if possible) via the distribution's package manager. On voidlinux, for example, I use the nerd-font package. For macOS, Homebrew is (probably) recommended. TBH: I have no idea if there exists something similar for Windows .. Scoop? .. and Scoop bucket for Nerd Fonts? |
|
Last two force push fixed issues when TERM is unset and/or the script is used in a pipe (e.g. Sorry for the force push mess / I hope I have now fixed last issues and PR is ready for review. |
ping @Finii .. if you have time, can you review / thanks .. |
Description
Add script to install directly from the GH releases / no need to clone
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
As long the PR is not merged use this branch (
return42/nerd-fonts/bs-install:Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)