这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@return42
Copy link

Description

Add script to install directly from the GH releases / no need to clone

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

How should this be manually tested?

As long the PR is not merged use this branch (return42/nerd-fonts/bs-install:

curl -s https://raw.githubusercontent.com/return42/nerd-fonts/bs-install/fc_install -o fc_install
chmod ugo+x fc_install
./fc_install --help
./fc_install install

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@return42 return42 marked this pull request as draft August 16, 2025 07:30
@return42 return42 force-pushed the bs-install branch 2 times, most recently from 6a76c98 to cc00577 Compare August 16, 2025 16:01
@return42 return42 marked this pull request as ready for review August 16, 2025 16:02
@Finii
Copy link
Collaborator

Finii commented Aug 16, 2025

Thanks for the PR, it looks very good!

Well, Im only on my phone right now and can not really examine.
But two things come to my mind:

Iirc we have MIT license for all scripts, that simple "rule" would break with the license you choose.

Second I do not get the dependency on fc-cache. I didnt encounter a system that needs a fc-cache call for years.

And third ;-) apple has this bash 3 only, i would tweak the script to avoid the newer features.

But, whatever, great work!

@return42
Copy link
Author

Iirc we have MIT license for all scripts,

Sorry for my ignorance about .. changed lic to MIT --> diff

Second I do not get the dependency on fc-cache.

fc-cache itself might not be needed, but the existence of this command ensures that a fontconfig freedesktop.org infrastructure (desktop vs. server distros) is installed .. if you insist, I can remove the use of fc-config.

apple has this bash 3 only

This script is written for Linux distros with a fontconfig freedesktop.org installation.

I sorted out my last Mac OS systems many years ago, but I suspect:

  • Apple shipped the 2007 version of Bash v3 and cannot upgrade to Bash 4 due to GPL3 restrictions.
  • Same with fontconfig / compared to what I know from Linux, Apple might have it own quirks (IDK but I would expect some differences)

Homebrew is the (missing/unofficially) package manager for Mac-OS and has a package for a updated version of bash .. however, Mac users are recommended to install the fonts from https://formulae.brew.sh/cask-font

@return42
Copy link
Author

To clarify: Installation scripts like the one in this PR do not replace a package manager; for example, this script does not offer automated updates (only manually or via a crontab entry).

Nerd Fonts should be installed (if possible) via the distribution's package manager. On voidlinux, for example, I use the nerd-font package. For macOS, Homebrew is (probably) recommended. TBH: I have no idea if there exists something similar for Windows .. Scoop? .. and Scoop bucket for Nerd Fonts?

@return42
Copy link
Author

return42 commented Aug 17, 2025

Last two force push fixed issues when TERM is unset and/or the script is used in a pipe (e.g. VERBOSE=2 ./fc_install list | grep Nerd).

Sorry for the force push mess / I hope I have now fixed last issues and PR is ready for review.

@return42
Copy link
Author

Well, Im only on my phone right now and can not really examine.

ping @Finii .. if you have time, can you review / thanks ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants