这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@mongolyy
Copy link
Contributor

@mongolyy mongolyy commented Jan 8, 2025

To adapt for reviewdog 0.20.2.
https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#v0202---2024-09-16

-fail-on-error flag was deprecated and added -fail-level flag (reviewdog/reviewdog#1854).

- uses: actions/setup-go@v5
with:
go-version: "1.20"
go-version: "1.23"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was still 1.20, the go install failed.

The shfmt necessary to be 1.22 or higher.
https://github.com/mvdan/sh?tab=readme-ov-file#sh

I updated it to the latest version, 1.23.

@mongolyy mongolyy mentioned this pull request Jan 8, 2025
Co-authored-by: Masaya Suzuki <15100604+massongit@users.noreply.github.com>
Copy link
Contributor

@massongit massongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@massongit massongit merged commit a3026c6 into reviewdog:master Jan 12, 2025
9 checks passed
@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.19.0 Changes:v1.18.0...v1.19.0

@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.20.0 Changes:v1.19.0...v1.20.0

penelopeysm added a commit to TuringLang/actions that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants