Deprecate fail-on-error
#64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Is reviewdog/action-rubocop#124 helpful? |
Contributor
Author
|
Hey thanks for the review. Sorry I must have missed the comment. Just note that I did not test run this code because I honestly don't know how to test stuff like this. I am also not good at bash scripts. So maybe extra attention is needed to double check I did everything right. |
Contributor
Author
|
PR is surpassed by #67 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr deprecates
fail-on-errorand replace them with-fail-level=error.Would be happy to implement
-fail-levelin another pr, but needs more directions on design and documentation.