Added support for skipping children #5
Conversation
This is particularly useful for avoiding greedy visiting when only a shallow parse is needed, e.g. to obtain method signatures, while skipping the methods' bodies.
|
Do you think we can use some kind of DI and make I might just be rambling. |
|
On second thought, let's go ahead with your PR. I thought about returning But I would much rather create |
|
|
|
I did this since I had some time today, hope you don't mind. I released 0.2.0 on crates.io. Hopefully, your refactor is working well. Ping me if you need anything else. |
This is particularly useful for avoiding greedy visiting when only a shallow parse is needed, e.g. to obtain method signatures, while skipping the methods' bodies.
I chose to pass a
skip_children: &mut bool(with default valuefalse), rather than adding anenum Children { Skip, Visit }and havingfn visit_*return-> Children(or whatever a better name would be), as the former allows for ignoring (for non-skipping semantics), while the latter would require aDefault::default()as the last line of every overridden method regardless.With
_semantics: &Semanticsremoved the method signatures should be fairly clean again.(Marking this as "draft" for now as it will result in a merge conflict. I'll do a manual rebase when it's time.)