Improve trait Visitor
#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will make it more generic and move Semantics out to keep it pure visitor crate. |
|
On second thought, I don't think any other argument is even needed since this is a trait. All the stuff people might need can be pushed into the type which is implementing this trait. @regexident What do you think about converting like below? fn $method(&mut self, _: &ast::$node, _semantics: &Semantics) {}to fn $method(&mut self, _: &ast::$node) {} |
|
Removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we already use a macro for scaffolding method signatures we might as well use it for scaffolding the corresponding match arms.
Took the opportunity to add the missing node types for completeness while I'm at it, in preparation for a possible extraction into a separate crate (Yes, please! 🙏🏻).
(I used rust-analyzer's /xtask/src/ast_src.rs file to source the node kinds.)