这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jakobsen-lrz
Copy link

@jakobsen-lrz jakobsen-lrz commented May 15, 2025

This changes the description of the hnaltqenable option, to reflect this change. And the generation of tunables to use the new hw.vtnet.altq_disable tunable.

I co-opted the hnaltqenable option under system/advanced/networking, and the config.xml option system/hn_altq_enable to implement this, because i did not want to change the format of config files used, and because it should be impossible for HN and VTNET NICs to exist on the same pfsense.

I hope this is fine, as the change was merged in some time ago, in the upstream freebsd repository, but isnt included yet in the pfsense/freebsd-src repository.

This changes the wording in www/system_advanced_network.php. And the generation of loader tunables in pfsense-utils.inc, to use the new tunable hw.vtnet.altq_disable

Signed-off-by: Bjoern <bjoern.jakobsen@lrz.de>
@jakobsen-lrz jakobsen-lrz force-pushed the vtnet-deactivate-altq-option branch from b6c0e0f to 1a3773f Compare May 15, 2025 08:44
@jim-p
Copy link
Contributor

jim-p commented May 15, 2025

We are in the middle of a release cycle at the moment so we have not synchronized the source with upstream recently. Once we have released CE 2.8.0 and Plus 25.03 and pulled in updated upstream source we can take a look at this.

@jakobsen-lrz
Copy link
Author

Do you synchronize the sources before the next release? So will pfsense CE 2.8.0 be based on the FreeBSD 15 Release, which isnt released before December? Even if this PR isnt added included in the pfsense CE 2.8.0 release, would i still like to use the new tunable.

@jim-p
Copy link
Contributor

jim-p commented May 15, 2025

During development cycles we periodically sync with FreeBSD-CURRENT/HEAD not a specific FreeBSD release.

We mark the commit at which we sync upstream on this page, though for in-development versions like Plus 25.07 that won't be fully updated until just before release: https://docs.netgate.com/pfsense/en/latest/releases/versions.html#x

@chrcoluk
Copy link

This is great you considering the request, , if its after 2.8.0 please put out a minor update for CE after its in.

@jakobsen-lrz
Copy link
Author

Hello, can this now go forward, 2.8.0 has been released, and the devel-main branch contains the necessary kernel change for the tunable to work.

I have also done a small change to the is_altq_capable function in interfaces.inc, as it would say that, a HN or VTNET interface is ALTQ capable, even if ALTQ support is disabled.

@jim-p
Copy link
Contributor

jim-p commented May 30, 2025

The hw.vtnet.altq_disable tunable is present now on internal 2.9 testing snapshots but there are other problems we are working on from the upstream src merge that prevent those snapshots from working properly yet. As such, this will also need to wait until after we get Plus 25.03 out so we can dedicate more resources to addressing issues with the latest upstream changes. But that shouldn't be too much more time at its current stage of its release cycle.

@nazar-pc
Copy link
Contributor

Any updates here?
pfSense Plus 25.07 was out a few months ago.

@jakobsen-lrz
Copy link
Author

Hello, can we get this MR merged in soon? If so i would fix the Conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants