-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add option to control ALTQ support for VTNET NICs #4733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add option to control ALTQ support for VTNET NICs #4733
Conversation
This changes the wording in www/system_advanced_network.php. And the generation of loader tunables in pfsense-utils.inc, to use the new tunable hw.vtnet.altq_disable Signed-off-by: Bjoern <bjoern.jakobsen@lrz.de>
b6c0e0f to
1a3773f
Compare
|
We are in the middle of a release cycle at the moment so we have not synchronized the source with upstream recently. Once we have released CE 2.8.0 and Plus 25.03 and pulled in updated upstream source we can take a look at this. |
|
Do you synchronize the sources before the next release? So will pfsense CE 2.8.0 be based on the FreeBSD 15 Release, which isnt released before December? Even if this PR isnt added included in the pfsense CE 2.8.0 release, would i still like to use the new tunable. |
|
During development cycles we periodically sync with FreeBSD-CURRENT/HEAD not a specific FreeBSD release. We mark the commit at which we sync upstream on this page, though for in-development versions like Plus 25.07 that won't be fully updated until just before release: https://docs.netgate.com/pfsense/en/latest/releases/versions.html#x |
|
This is great you considering the request, , if its after 2.8.0 please put out a minor update for CE after its in. |
…interfaces with disabled ALTQ support
|
Hello, can this now go forward, 2.8.0 has been released, and the devel-main branch contains the necessary kernel change for the tunable to work. I have also done a small change to the |
|
The |
|
Any updates here? |
|
Hello, can we get this MR merged in soon? If so i would fix the Conflicts. |
…ster and fixed merge conflicts
This changes the description of the hnaltqenable option, to reflect this change. And the generation of tunables to use the new
hw.vtnet.altq_disabletunable.I co-opted the hnaltqenable option under
system/advanced/networking, and the config.xml optionsystem/hn_altq_enableto implement this, because i did not want to change the format of config files used, and because it should be impossible for HN and VTNET NICs to exist on the same pfsense.I hope this is fine, as the change was merged in some time ago, in the upstream freebsd repository, but isnt included yet in the pfsense/freebsd-src repository.